-
Notifications
You must be signed in to change notification settings - Fork 92
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
Cross grid seed dispersal #1005
Conversation
Update to `sci.1.57.2_api.23.0.0` and add distance utilities
I'm finding that exact restarts when seed dispersal is on is not B4B. Investigating. Note that this is not part of the official regression testing list at this time. |
ERS testing is passing b4b now with commits e5cd151 and ESCOMP/CTSM@e978870. An e3sm version of the latter commit is forthcoming along with rerunning of the standard regression tests. UPDATE: e3sm commit is E3SM-Project/E3SM@b11b83c |
It looks like the ERS fix did not address the thread/task switching restart ERP tests, all of which are failing Failing tests:
|
Per recommendation from @adrifoster, I've refactored the code on both the hlm and fates side to utilize a namelist switch to handle the seed dispersal cadence, which will also allow the user to turn off seed dispersal without modifying the parameter file. The code is still not b4b across different pe layouts, but I've generated #1089 to note this track this to be fixed on a future PR. |
Retesting the with the Cheyenne: |
Changes all occurances of "hite" to "height"
Re-running cheyenne: |
…sal' into next (PR #5555) This PR enables FATES to disperse seeds across neighboring grid cells using MPI. The API update includes calls to new fates dispersal procedures and as such should be coordinated with NGEET/fates#1005. [B4B] except for FATES
…sal' (PR #5555) This PR enables FATES to disperse seeds across neighboring grid cells using MPI. The API update includes calls to new fates dispersal procedures and as such should be coordinated with NGEET/fates#1005. [B4B] except for FATES
This PR implements cross grid seed dispersal, allowing seed exchange among neighboring grids.
Description:
Resolves #471
Collaborators:
I wrote the initial version with help of @jenniferholm, in discussion with @ckoven, @rgknox, and @slevisconsulting. @glemieux significantly improved the version by implementing wrap functions, dispersal kernels, updated parameter files, and improved ELM-FATES interface.
Expectation of Answer Changes:
When turned on, cross grid seed dispersal is expected to change seed bank storage thus PFT composition. The cross grid seed dispersal can be turned off by setting the fates_seed_dispersal_fraction parameter to zero.
Checklist:
Test Results:
Not yet tested
CTSM (or) E3SM (specify which) test hash-tag:
CTSM (or) E3SM (specify which) baseline hash-tag:
FATES baseline hash-tag:
Test Output: