-
Notifications
You must be signed in to change notification settings - Fork 38
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
Manually Ports That /tg/ Kinesis Rework But With Even More Powercreep #310
base: master
Are you sure you want to change the base?
Conversation
… into kinesisrework # Conflicts: # tgstation.dme
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
you can make a lot of this modular very easily, check the parts i've put reviews on
@@ -262,19 +266,49 @@ | |||
removable = FALSE | |||
core_removable = FALSE | |||
|
|||
/// DOPPLER EDIT START - weak version of the kinesis module for engineers |
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
this entire block you can add in a module file
prebuilt = TRUE | ||
|
||
/// researchable and printable | ||
/obj/item/mod/module/anomaly_locked/kinesis/upgraded |
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
same here
stat_required = CONSCIOUS | ||
|
||
// DOPPLER EDIT START - For The Kinesis Rework |
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
and here
/// Admin suit version of kinesis. Can grab anything at any range, may enable phasing through walls. | ||
/obj/item/mod/module/anomaly_locked/kinesis/admin | ||
name = "MOD kinesis++ module" | ||
name = "MOD omega kinesis++ module" // DOPPLER EDIT CHANGE - For The Kinesis Rework - Original: "MOD kinesis++ module" |
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
you can do this rename in a module file
/obj/item/mod/module/anomaly_locked/kinesis/plus | ||
name = "MOD kinesis+ module" | ||
desc = "A modular plug-in to the forearm, this module was recently redeveloped in secret. \ | ||
name = "MOD kinesis plus module" // DOPLPER EDIT CHANGE - For The Kinesis Rework - Original: "MOD kinesis+ module" |
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
you can change all these variables in a modular file
@@ -34,6 +34,8 @@ | |||
var/datum/looping_sound/gravgen/kinesis/soundloop | |||
/// The cooldown between us hitting objects with kinesis. | |||
COOLDOWN_DECLARE(hit_cooldown) | |||
/// DOPPLER EDIT ADDITION - Can this module launch grabbed items? |
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
you can add this in a modular file
@@ -427,6 +427,8 @@ | |||
var/prebuilt = FALSE | |||
/// If the core is removable once socketed. | |||
var/core_removable = TRUE | |||
/// DOPPLER EDIT ADDITION - If true, removes all mentions of the anomaly core inside and interactions with the core inside. This is done so subtypes can inherit behaviors and become anomaly locked. |
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
you can add this in a modular file instead
@@ -2757,19 +2757,31 @@ | |||
) | |||
|
|||
/datum/design/module/mod_kinesis | |||
name = "Kinesis Module" | |||
name = "Experimental Kinesis Module" //DOPPLER EDIT CHANGE - For The Kinesis Rework - Original: "Kinesis Module" |
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
this can be renamed modularly
id = "mod_kinesis" | ||
materials = list( | ||
/datum/material/iron = SHEET_MATERIAL_AMOUNT *1.25, | ||
/datum/material/glass =SHEET_MATERIAL_AMOUNT, | ||
/datum/material/uranium =HALF_SHEET_MATERIAL_AMOUNT, | ||
/datum/material/bluespace =HALF_SHEET_MATERIAL_AMOUNT, | ||
) | ||
build_path = /obj/item/mod/module/anomaly_locked/kinesis | ||
build_path = /obj/item/mod/module/anomaly_locked/kinesis/upgraded //DOPPLER EDIT CHANGE - For The Kinesis Rework - Original: /obj/item/mod/module/anomaly_locked/kinesis |
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
this can be changed modular
category = list( | ||
RND_CATEGORY_MODSUIT_MODULES + RND_SUBCATEGORY_MODSUIT_MODULES_ENGINEERING | ||
) | ||
|
||
//DOPPLER EDIT ADDITION START - For The Kinesis Rework |
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
this can be added in a modular file
About The Pull Request
A nerfed kinesis module named the "MOD magnalock module" is now by default in an engineering MODsuit.
A slightly better kinesis module named the "MOD experimental kinesis module" is given to the Chief engineer's MODsuit.
The same as the magnalock module but:
Medical also gets the CE's one because God knows Medical MODsuits are fucking useless in comparison to the utility of Engineering suits, and the CMO gets a defibrillator module by default. Let me know if only the CMO should get this.
You can also research the magnalock one pretty early.
Why It's Good For The Game
Changelog
🆑
add: The magnalock module has been added to engineering MODsuits.
add: The experimental kinesis module has been added to the Chief Engineer's MODsuit and both Medical suits.
balance: The CMO now gets a defibrillator in their MODsuit.
/:cl: