Add super subclass plugs. #627
Closed
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
2 tasks
robojumper
reviewed
Jun 7, 2024
SEASONS.md
Outdated
| | 21 | 23MAY2023 | 21AUG2023 | | the Deep | | ||
| | 22 | 22AUG2023 | 27NOV2023 | | the Witch | | ||
| | 23 | 28NOV2023 | 03JUN2024 | | the Wish | | ||
| | 24 | 04JUN2024 | 07OCT2024 | The Final Shape | Episode: Echoes | |
There was a problem hiding this comment.
The script that generates these should probably use UTC...
There was a problem hiding this comment.
Thanks for that, hard reverted the change but yeah we should probably fix that one
robojumper
reviewed
Jun 7, 2024
| @@ -0,0 +1,17 @@ | |||
| [ | |||
There was a problem hiding this comment.
README.md documents these output files in a table, wouldn't hurt to add this one too.
delphiactual
approved these changes
Jun 9, 2024
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Overview
This adds data to know whether a given plug category comes from a subclass super. The intent is to know whether we should show the 45 degree border for these plugs or not.
Context: Now that prismatic is here we have a round super icon rather than the old diamond. In DestinyItemManager/DIM#10513 I am proposing we don't change the subclass icon for the super icon and that we display the super as a plug. To do this properly, we need to be able to identify which plugs are super icons as they all the diamond shape.
Example plugs