Show subclass super #10513
Show subclass super #10513
Conversation
| @@ -101,6 +101,7 @@ export default function LoadoutEditSubclass({ | |||
| // plugs in the loadout and they may be different to the popup | |||
| onClick={plugs.length ? undefined : onClick} | |||
| item={subclass.item} | |||
| hideSelectedSuper | |||
There was a problem hiding this comment.
Maybe we just remove this prop altogether from inventory item and do this by default?
| export const prismaticSubclassHashes = [ | ||
| 1616346845, // titan | ||
| 3893112950, // warlock | ||
| 4282591831, // hunter |
There was a problem hiding this comment.
The only other way I can see to do this atm is trait id's ("item.subclass.prism") and from memory we avoid them? See https://data.destinysets.com/i/InventoryItem:3893112950
There was a problem hiding this comment.
I just found we generate the trait hash, but we don't have the information available for the inventory item. Let me know how you want to solve this as I don't love the hardcoded hashes here.
|
I think I'd like to see if we can try and preserve the current behavior of highlighting the current super. The way we do it for the other subclasses is we have a manually edited background and then we overlay the super icon - if we do the same with prismatic, we'd have a diamond with the proper super inside a pink circle, and I think it'd still be clear that it's prismatic. My worry with putting the super in with the other subclass plugs is that it's kind of hard to pick out. |
|
Happy to give that a go. I also had that thought but personally prefer this way conceptually. I'll put something together when I get a chance if someone doesn't beat me. |
|
|
|
I think I'd be OK with this if the super were in a diamond. |
|
Closing since the other approach merged. |
Overview
This changes the loadout code so that we show the super at all times. This change largely accommodates prismatic, which doesn't replace the icon with the super icon. I think this behaviour is desirable for prismatic as its not really the same as whatever super you are running due to transcendence.
TODO
Before
After