11 automate spatial feature specification #14
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
atuldeshpande
requested changes
Jul 25, 2024
R/preprocessing.R
Outdated
| } | ||
| spFeatures <- spFeatures[,featureNames] | ||
|
|
||
| featureNames <- intersect(featureNames,colnames(spFeatures)) |
There was a problem hiding this comment.
There could be a case where user lists 6 patterns but we find only 5 in the object. How should we handle that?
- Message which reports that we did not find all patterns, and are continuing with the rest.
- Error which reports the specific patterns we did not find, and ask user to check input.
I note that this scenario may be more common in non-pipeline use cases.
There was a problem hiding this comment.
addressed in cd2ab20
atuldeshpande
approved these changes
Jul 30, 2024
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
refactor:
featureNames=NULLsince checking with regex"."does the same and is shorterif elseand messagesready to automate spatial feature specification now.