Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

test: Isolate integration, external tests #1156

Merged
merged 18 commits into from
Nov 3, 2024
Merged

Conversation

DaveSkender
Copy link
Owner

@DaveSkender DaveSkender commented Jan 28, 2024

Description

Tests that use live data feeds or represent other forms of integration, such as end use of the package, should be separated from our normal unit test runs to avoid the slippery slope of cross-domain e2e forms. This isolation ensures we do not run these during normal local development unit test runs where speed and true unit test coverage are important.

Separating tests that reflect:

  • use of external data feeds
  • use of library as external package (pure UX tests)

To do

  • add conditional and/or manual run triggers for local development
  • add conditional and/or manual run triggers in CI/CD pipelines
  • move External test portions from unit tests
  • add ~5 missing unit tests for coverage

@DaveSkender DaveSkender added the on hold On hold / waiting label Jan 28, 2024
@DaveSkender DaveSkender added this to the v3 milestone Jan 28, 2024
@DaveSkender DaveSkender changed the title move external feed test to new project test: Isolate integration, external tests Jan 28, 2024

This comment was marked as outdated.

@DaveSkender DaveSkender self-assigned this Mar 31, 2024
@DaveSkender DaveSkender removed the on hold On hold / waiting label Nov 2, 2024
@DaveSkender DaveSkender marked this pull request as ready for review November 3, 2024 03:53
@DaveSkender DaveSkender enabled auto-merge (squash) November 3, 2024 03:54
@DaveSkender DaveSkender disabled auto-merge November 3, 2024 03:55
@DaveSkender DaveSkender enabled auto-merge (squash) November 3, 2024 03:59
@DaveSkender DaveSkender merged commit 070a00e into v3 Nov 3, 2024
15 checks passed
@DaveSkender DaveSkender deleted the refactor-integration-tests branch November 3, 2024 04:07
@github-actions github-actions bot locked as resolved and limited conversation to collaborators Dec 8, 2024
Sign up for free to subscribe to this conversation on GitHub. Already have an account? Sign in.
Labels
None yet
Projects
Archived in project
Development

Successfully merging this pull request may close these issues.

1 participant