Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

test: Remove live feed unit tests #1157

Merged
merged 2 commits into from
Jan 28, 2024
Merged

test: Remove live feed unit tests #1157

merged 2 commits into from
Jan 28, 2024

Conversation

DaveSkender
Copy link
Owner

Description

As a better practice, we're replacing the one live data feed unit test with a static one and removing the live feed test rig. We'll be adding a separate integration test setup later.

Checklist

  • My code follows the existing style, code structure, and naming taxonomy
  • I have put comments in my code, particularly for hard-to-understand areas
  • I have performed a self-review of my code and included any verifying manual calculations
  • I have added or updated unit tests that prove my fix is effective or that my feature works and achieves sufficient code coverage. New and existing unit tests pass locally and in the build (below) with my changes
  • My changes generate no new warnings or other code analysis issues
  • I have added or run the performance tests that depict optimal execution times
  • I have made corresponding changes to the documentation

Related

Copy link

✔️ Tests 718 / 718 - passed in 6s
📝 Coverage 96.57%
📏 5308 / 5311 lines covered 🌿 2296 / 2563 branches covered
🔍 click here for more details

@DaveSkender DaveSkender enabled auto-merge (squash) January 28, 2024 18:22
@DaveSkender DaveSkender merged commit 766eeb3 into main Jan 28, 2024
6 of 7 checks passed
@DaveSkender DaveSkender deleted the fix-test-1127 branch January 28, 2024 18:22
@github-actions github-actions bot locked as resolved and limited conversation to collaborators Mar 3, 2024
Sign up for free to subscribe to this conversation on GitHub. Already have an account? Sign in.
Labels
None yet
Projects
Archived in project
Development

Successfully merging this pull request may close these issues.

1 participant