Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

[AMLII-1828] Cleaning up pom.xml #529

Merged
merged 8 commits into from
Jul 12, 2024
Merged

[AMLII-1828] Cleaning up pom.xml #529

Changes from all commits
Commits
Show all changes
8 commits
Select commit Hold shift + click to select a range
06675b0
Moved versions in pom to params for consistency
carlosroman Jun 10, 2024
beb9054
Bump testcontainers to 1.19.8
carlosroman Jun 10, 2024
d569f8e
Bump maven-gpg-plugin to 3.2.4
carlosroman Jun 10, 2024
b4ccc79
Bump maven-deploy-plugin to 3.1.2
carlosroman Jun 10, 2024
7e07f7b
Bumping hamcrest to 2.2
carlosroman Jun 10, 2024
0264130
Bumping lombok to 1.18.32
carlosroman Jun 10, 2024
f3c3da4
Bumping buildnumber-maven-plugin to 3.1.0
carlosroman Jun 19, 2024
83b5134
Bumping nexus-staging-maven-plugin to 1.7.0
carlosroman Jun 19, 2024
File filter

Filter by extension

Filter by extension
Conversations
Failed to load comments.
Loading
Jump to
Jump to file
Failed to load files.
Loading
Diff view
Diff view
59 changes: 35 additions & 24 deletions pom.xml
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -35,31 +35,36 @@
<maven.compiler.source>1.7</maven.compiler.source>
<maven.compiler.target>1.7</maven.compiler.target>

<commons-io.version>2.4</commons-io.version>
<apache-commons-lang3.version>3.5</apache-commons-lang3.version>
<java-dogstatsd-client.version>2.10.5</java-dogstatsd-client.version>
<jcommander.version>1.35</jcommander.version>
<slf4j.version>1.7.32</slf4j.version>
<jackson.version>2.12.3</jackson.version>
<snakeyaml.version>2.0</snakeyaml.version>
<maven-deploy-plugin.version>3.1.1</maven-deploy-plugin.version>
<buildnumber-maven-plugin.version>3.1.0</buildnumber-maven-plugin.version>
<maven-assembly-plugin.version>3.1.0</maven-assembly-plugin.version>
<maven-checkstyle-plugin.version>3.0.0</maven-checkstyle-plugin.version>
<maven-deploy-plugin.version>3.1.2</maven-deploy-plugin.version>
<maven-gpg-plugin.version>3.2.4</maven-gpg-plugin.version>
<maven-javadoc-plugin.version>3.2.0</maven-javadoc-plugin.version>
<maven-source-plugin.version>3.0.1</maven-source-plugin.version>
<maven-surefire-plugin.version>2.9</maven-surefire-plugin.version>
<nexus-staging-maven-plugin.version>1.7.0</nexus-staging-maven-plugin.version>
<!-- Note: using project checkstyle with AOSP style
find the default google java checkstyle config here -
<checkstyle.config.location>google_checks.xml</checkstyle.config.location>
-->
<checkstyle.config.location>style.xml</checkstyle.config.location>


<apache-commons-lang3.version>3.5</apache-commons-lang3.version>
<commons-io.version>2.4</commons-io.version>
<hamcrest.version>2.2</hamcrest.version>
<jackson.version>2.12.3</jackson.version>
<java-dogstatsd-client.version>2.10.5</java-dogstatsd-client.version>
<javax.management.j2ee-api.version>1.1.2</javax.management.j2ee-api.version>
<jcommander.version>1.35</jcommander.version>
<junit.version>4.13.2</junit.version>
<lombok.version>1.18.32</lombok.version>
<mockito.version>2.28.2</mockito.version>

<maven-surefire-plugin.version>2.9</maven-surefire-plugin.version>
<buildnumber-maven-plugin.version>1.4</buildnumber-maven-plugin.version>
<maven-source-plugin.version>3.0.1</maven-source-plugin.version>
<maven-assembly-plugin.version>3.1.0</maven-assembly-plugin.version>
<slf4j.version>1.7.32</slf4j.version>
<snakeyaml.version>2.0</snakeyaml.version>
<testcontainers.version>1.19.8</testcontainers.version>

<project.build.sourceEncoding>UTF-8</project.build.sourceEncoding>

<project.scm.id>github</project.scm.id>
</properties>

Expand Down Expand Up @@ -95,7 +100,7 @@
<plugin>
<groupId>org.sonatype.plugins</groupId>
<artifactId>nexus-staging-maven-plugin</artifactId>
<version>1.6.13</version>
<version>${nexus-staging-maven-plugin.version}</version>
Copy link
Contributor

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Just curious, what is the advantage of specifying the version via a property?

Copy link
Contributor Author

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

I went back and forth between specifying them in property or just moving them out of property completely or moving it all to dependency-management section. I was aiming for some consistency while I went through and upgraded some of the plugins and dependencies as we had mixture.

<extensions>true</extensions>
<configuration>
<serverId>nexus</serverId>
Expand All @@ -108,7 +113,7 @@
<plugin>
<groupId>org.apache.maven.plugins</groupId>
<artifactId>maven-gpg-plugin</artifactId>
<version>3.0.1</version>
<version>${maven-gpg-plugin.version}</version>
<executions>
<execution>
<id>sign-artifacts</id>
Expand Down Expand Up @@ -166,7 +171,7 @@
<dependency>
<groupId>org.projectlombok</groupId>
<artifactId>lombok</artifactId>
<version>1.18.22</version>
<version>${lombok.version}</version>
<scope>provided</scope>
</dependency>
<dependency>
Expand All @@ -188,7 +193,7 @@
<dependency>
<groupId>javax.management.j2ee</groupId>
<artifactId>javax.management.j2ee-api</artifactId>
<version>1.1.2</version>
<version>${javax.management.j2ee-api.version}</version>
<scope>test</scope>
</dependency>

Expand All @@ -207,13 +212,19 @@
<dependency>
<groupId>org.testcontainers</groupId>
<artifactId>testcontainers</artifactId>
<version>1.19.3</version>
<version>${testcontainers.version}</version>
<scope>test</scope>
</dependency>
<dependency>
<groupId>org.hamcrest</groupId>
<artifactId>hamcrest</artifactId>
<version>${hamcrest.version}</version>
<scope>test</scope>
</dependency>
<dependency>
<groupId>org.hamcrest</groupId>
<artifactId>hamcrest-library</artifactId>
<version>1.3</version>
<version>${hamcrest.version}</version>
<scope>test</scope>
</dependency>
</dependencies>
Expand Down Expand Up @@ -284,7 +295,7 @@
<plugin>
<groupId>org.apache.maven.plugins</groupId>
<artifactId>maven-javadoc-plugin</artifactId>
<version>3.2.0</version>
<version>${maven-javadoc-plugin.version}</version>
<executions>
<execution>
<id>attach-javadocs</id>
Expand Down Expand Up @@ -325,7 +336,7 @@
<plugin>
<groupId>org.apache.maven.plugins</groupId>
<artifactId>maven-checkstyle-plugin</artifactId>
<version>3.0.0</version>
<version>${maven-checkstyle-plugin.version}</version>
<executions>
<execution>
<id>checkstyle</id>
Expand Down Expand Up @@ -361,7 +372,7 @@
<plugin>
<groupId>org.apache.maven.plugins</groupId>
<artifactId>maven-checkstyle-plugin</artifactId>
<version>3.0.0</version>
<version>${maven-checkstyle-plugin.version}</version>
<reportSets>
<reportSet>
<reports>
Expand Down
Loading