[AMLII-1828] Cleaning up pom.xml #529
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
carlosroman
force-pushed
the
carlosroman/AMLII-1828-pom-tidy
branch
from
5fa6ad9 to
ba7b648
Compare
carlosroman
force-pushed
the
carlosroman/AMLII-1828-pom-tidy
branch
from
3c45d29 to
171f467
Compare
carlosroman
force-pushed
the
carlosroman/AMLII-1828-pom-tidy
branch
from
7d1968c to
311e4a6
Compare
carlosroman
force-pushed
the
carlosroman/AMLII-1828-pom-tidy
branch
from
750e9c1 to
83b5134
Compare
vickenty
approved these changes
Jul 12, 2024
| @@ -95,7 +100,7 @@ | |||
| <plugin> | |||
| <groupId>org.sonatype.plugins</groupId> | |||
| <artifactId>nexus-staging-maven-plugin</artifactId> | |||
| <version>1.6.13</version> | |||
| <version>${nexus-staging-maven-plugin.version}</version> | |||
There was a problem hiding this comment.
Just curious, what is the advantage of specifying the version via a property?
There was a problem hiding this comment.
I went back and forth between specifying them in property or just moving them out of property completely or moving it all to dependency-management section. I was aiming for some consistency while I went through and upgraded some of the plugins and dependencies as we had mixture.
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Cleaned up the
pom.xmland bumped some of the dependencies. Deployments still work after all the changes (seeSNAPSHOThere).