-
Notifications
You must be signed in to change notification settings - Fork 1.4k
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
[LOI-346] Milvus Logs #19331
Open
dkirov-dd
wants to merge
12
commits into
master
Choose a base branch
from
david.kirov/milvus-logs
base: master
Could not load branches
Branch not found: {{ refName }}
Loading
Could not load tags
Nothing to show
Loading
Are you sure you want to change the base?
Some commits from the old base branch may be removed from the timeline,
and old review comments may become outdated.
Open
[LOI-346] Milvus Logs #19331
Changes from 4 commits
Commits
Show all changes
12 commits
Select commit
Hold shift + click to select a range
67032bc
Add logs assets
dkirov-dd d8fa17b
Update README
dkirov-dd 7dc7404
Fix logs assets
dkirov-dd 617114f
Add test results
dkirov-dd 1676aca
Add logs to spec.yaml
dkirov-dd 48a5f96
Update manifest
dkirov-dd 1e62633
Add saved views
dkirov-dd 9448186
Add changelog
dkirov-dd dbd7747
Improve message_rule
dkirov-dd 8553bda
Add second parsing rule
dkirov-dd f7d8eec
Replace data with regex in parsing rule 1
dkirov-dd 03b9cdc
Add quotes to samples
dkirov-dd File filter
Filter by extension
Conversations
Failed to load comments.
Loading
Jump to
Jump to file
Failed to load files.
Loading
Diff view
Diff view
There are no files selected for viewing
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
| Original file line number | Diff line number | Diff line change |
|---|---|---|
| @@ -0,0 +1,52 @@ | ||
| id: milvus | ||
| metric_id: milvus | ||
| backend_only: false | ||
| facets: null | ||
| pipeline: | ||
| type: pipeline | ||
| name: Milvus | ||
| enabled: true | ||
| filter: | ||
| query: source:milvus | ||
| processors: | ||
| - type: grok-parser | ||
| name: Grok Parser | ||
| enabled: true | ||
| source: message | ||
| samples: | ||
| - '[2024/11/27 14:07:51.849 +00:00] [INFO] [datacoord/handler.go:341] | ||
| ["channel seek position set from channel checkpoint meta"] | ||
| [channel=by-dev-rootcoord-dml_2_453764875273209568v0] | ||
| [posTs=454221223538458625] [posTime=2024/11/27 14:07:39.421 +00:00]' | ||
| - '[2024/11/27 14:07:01.849 +00:00] [INFO] [datacoord/services.go:833] | ||
| ["datacoord append channelInfo in GetRecoveryInfo"] | ||
| [traceID=ed216b196edf0589f281c4ad800f6565] | ||
| [collectionID=453764875273209568] [partitionIDs="[]"] | ||
| [channel=by-dev-rootcoord-dml_2_453764875273209568v0] ["# of unflushed | ||
| segments"=0] ["# of flushed segments"=1] ["# of dropped segments"=0] | ||
| ["# of indexed segments"=0] ["# of l0 segments"=0]' | ||
| - '[2024/11/27 14:06:51.852 +00:00] [INFO] [datacoord/services.go:818] | ||
| ["get recovery info request received"] | ||
| [traceID=54cda8d3229d00982db785351a12ea7a] | ||
| [collectionID=453764875273212700] [partitionIDs="[]"]' | ||
| grok: | ||
| supportRules: message_rule | ||
| \[?(")%{data:message.body}?(")]\s+%{data:message.details:array("[]","] | ||
| [")} | ||
| matchRules: rule1 \[%{date("yyyy/MM/dd HH:mm:ss.SSS | ||
| ZZ"):date}]\s+\[%{word:level}\]\s+\[%{word:service}/%{notSpace:file}:%{word:lineno}\]\s+%{message_rule} | ||
| - type: status-remapper | ||
| name: Define `level` as the official status of the log | ||
| enabled: true | ||
| sources: | ||
| - level | ||
| - type: message-remapper | ||
| name: Define `message.body` as the official message of the log | ||
| enabled: true | ||
| sources: | ||
| - message.body | ||
| - type: date-remapper | ||
| name: Define `date` as the official date of the log | ||
| enabled: true | ||
| sources: | ||
| - date | ||
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
| Original file line number | Diff line number | Diff line change |
|---|---|---|
| @@ -0,0 +1,65 @@ | ||
| id: milvus | ||
| tests: | ||
| - | ||
| sample: "[2024/11/27 14:07:51.849 +00:00] [INFO] [datacoord/handler.go:341] [\"channel seek position set from channel checkpoint meta\"] [channel=by-dev-rootcoord-dml_2_453764875273209568v0] [posTs=454221223538458625] [posTime=2024/11/27 14:07:39.421 +00:00]" | ||
| result: | ||
| custom: | ||
| date: 1732716471849 | ||
| file: "handler.go" | ||
| level: "INFO" | ||
| lineno: "341" | ||
| message: | ||
| details: | ||
| - "channel=by-dev-rootcoord-dml_2_453764875273209568v0" | ||
| - "posTs=454221223538458625" | ||
| - "posTime=2024/11/27 14:07:39.421 +00:00" | ||
| service: "datacoord" | ||
| message: "channel seek position set from channel checkpoint meta" | ||
| status: "info" | ||
| tags: | ||
| - "source:LOGS_SOURCE" | ||
| timestamp: 1732716471849 | ||
| - | ||
| sample: "[2024/11/27 14:07:01.849 +00:00] [INFO] [datacoord/services.go:833] [\"datacoord append channelInfo in GetRecoveryInfo\"] [traceID=ed216b196edf0589f281c4ad800f6565] [collectionID=453764875273209568] [partitionIDs=\"[]\"] [channel=by-dev-rootcoord-dml_2_453764875273209568v0] [\"# of unflushed segments\"=0] [\"# of flushed segments\"=1] [\"# of dropped segments\"=0] [\"# of indexed segments\"=0] [\"# of l0 segments\"=0]" | ||
| result: | ||
| custom: | ||
| date: 1732716421849 | ||
| file: "services.go" | ||
| level: "INFO" | ||
| lineno: "833" | ||
| message: | ||
| details: | ||
| - "traceID=ed216b196edf0589f281c4ad800f6565" | ||
| - "collectionID=453764875273209568" | ||
| - "partitionIDs=\"[]\"" | ||
| - "channel=by-dev-rootcoord-dml_2_453764875273209568v0" | ||
| - "\"# of unflushed segments\"=0" | ||
| - "\"# of flushed segments\"=1" | ||
| - "\"# of dropped segments\"=0" | ||
| - "\"# of indexed segments\"=0" | ||
| - "\"# of l0 segments\"=0" | ||
| service: "datacoord" | ||
| message: "datacoord append channelInfo in GetRecoveryInfo" | ||
| status: "info" | ||
| tags: | ||
| - "source:LOGS_SOURCE" | ||
| timestamp: 1732716421849 | ||
| - | ||
| sample: "[2024/11/27 14:06:51.852 +00:00] [INFO] [datacoord/services.go:818] [\"get recovery info request received\"] [traceID=54cda8d3229d00982db785351a12ea7a] [collectionID=453764875273212700] [partitionIDs=\"[]\"]" | ||
| result: | ||
| custom: | ||
| date: 1732716411852 | ||
| file: "services.go" | ||
| level: "INFO" | ||
| lineno: "818" | ||
| message: | ||
| details: | ||
| - "traceID=54cda8d3229d00982db785351a12ea7a" | ||
| - "collectionID=453764875273212700" | ||
| - "partitionIDs=\"[]\"" | ||
| service: "datacoord" | ||
| message: "get recovery info request received" | ||
| status: "info" | ||
| tags: | ||
| - "source:LOGS_SOURCE" | ||
| timestamp: 1732716411852 |
Oops, something went wrong.
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
\[?(")%{data:message.body}?(")])? Unless I misread, I am confused by the fact that:\[?means that the brackets are optional(")Or is the goal to make the quotes optional in the message.body block (in which case we might need to slightly adjust the expression)?
\[?(")%{data:message.body}?(")]more efficient by replacing the use ofdataby the following regex:%{regex("[^]]*"):message.body}(ie matching up to the delimiter:]).There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Thanks for the feedback!
?(")is intended to make the quotes optional. I see that it is incorrect, I'll change that.message_rule \["?%{data:message.body}"?](\s+%{data:message.details:array("[]","] [")})?Here is an example log that would be covered by this change:
[2024/11/18 15:15:45.120 +00:00] [INFO] [roles/roles.go:282] [setupPrometheusHTTPServer]There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
No problem, I think your latest changes make sense.
Could you just replace the
%{data:message.body}as suggested, as having multipledatain the grok expression tends to be quite costly to evaluate, with possible side-effects if it ends up taking too long (ie we might have to abort parsing the expression). Replacing it with%{regex("[^]]*"):message.body}should alleviate the issue a bit.