Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

[LOI-346] Milvus Logs #19331

Open
wants to merge 8 commits into
base: master
Choose a base branch
from
Open

[LOI-346] Milvus Logs #19331

wants to merge 8 commits into from

Conversation

dkirov-dd
Copy link
Contributor

  • Add logs assets
  • Update README

What does this PR do?

Motivation

Review checklist (to be filled by reviewers)

  • Feature or bugfix MUST have appropriate tests (unit, integration, e2e)
  • Add the qa/skip-qa label if the PR doesn't need to be tested during QA.
  • If you need to backport this PR to another branch, you can add the backport/<branch-name> label to the PR and it will automatically open a backport PR once this one is merged

@dkirov-dd dkirov-dd requested review from a team as code owners January 2, 2025 11:39
@dkirov-dd dkirov-dd changed the title Milvus Logs [LOI-346] Milvus Logs Jan 2, 2025
@dkirov-dd dkirov-dd force-pushed the david.kirov/milvus-logs branch 2 times, most recently from 207a44e to 5250055 Compare January 2, 2025 12:11
@dkirov-dd dkirov-dd force-pushed the david.kirov/milvus-logs branch from 5250055 to 7dc7404 Compare January 2, 2025 12:16
cswatt
cswatt previously approved these changes Jan 2, 2025
Copy link

codecov bot commented Jan 2, 2025

Codecov Report

All modified and coverable lines are covered by tests ✅

Project coverage is 87.61%. Comparing base (e6b077a) to head (a0edcb6).
Report is 3 commits behind head on master.

Additional details and impacted files
Flag Coverage Δ
activemq ?
cassandra ?
hive ?
hivemq ?
hudi ?
ignite ?
jboss_wildfly ?
kafka ?
milvus 92.30% <ø> (ø)
presto ?
solr ?

Flags with carried forward coverage won't be shown. Click here to find out more.

HadhemiDD
HadhemiDD previously approved these changes Jan 3, 2025
@dkirov-dd dkirov-dd force-pushed the david.kirov/milvus-logs branch from b416aed to a0edcb6 Compare January 3, 2025 16:11
@dkirov-dd dkirov-dd force-pushed the david.kirov/milvus-logs branch from a0edcb6 to 9448186 Compare January 3, 2025 16:22
@dkirov-dd dkirov-dd requested review from cswatt and HadhemiDD January 3, 2025 16:24
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Projects
None yet
Development

Successfully merging this pull request may close these issues.

3 participants