Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

WOR-1810: Hide azure apps from Cloud Environments page #5041

Merged
merged 2 commits into from
Aug 29, 2024
Merged

Conversation

rtitle
Copy link
Contributor

@rtitle rtitle commented Aug 29, 2024

Jira Ticket: https://broadworkbench.atlassian.net/browse/WOR-1810

Summary of changes:

What

Why

  • Users are seeing public CBAS and CROMWELL_RUNNER apps they did not create in the Cloud Environments screen, which is confusing. This is because the UI lists all apps the user has access to with the saturnAutoCreated label. For WOR-1810 we decided to just hide these app types from the Cloud Environments screen. Removing the label accomplishes that. No other Azure workspace functionality depends on this label.
  • Note this mirrors the behavior for WDS: WDS apps do not use the saturnAutoCreated label and thus they are hidden from the Cloud Environments screen.

Testing strategy

Tested in a BEE via the following steps:

  1. Created Azure workspace (WDS, CBAS, and Cromwell apps) using dev code
  2. Verified I see CBAS and Cromwell in the Cloud Envs screen
  3. Created Azure workspace using PR code
  4. Verified workspace functionality still works
  5. Verified I do not see Azure apps from (3) in Cloud Envs screen
  6. Deployed Leo migration PR
  7. Verified I no longer see any Azure apps in the Cloud Envs screen

Copy link

sonarcloud bot commented Aug 29, 2024

@rtitle rtitle added this pull request to the merge queue Aug 29, 2024
Merged via the queue into dev with commit ca9fc77 Aug 29, 2024
10 checks passed
@rtitle rtitle deleted the rt-wor-1810 branch August 29, 2024 15:22
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

4 participants