Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

WOR-1810: Hide azure apps from Cloud Environments page #4772

Merged
merged 3 commits into from
Aug 29, 2024
Merged

Conversation

rtitle
Copy link
Collaborator

@rtitle rtitle commented Aug 29, 2024

Jira ticket: https://broadworkbench.atlassian.net/browse/WOR-1810

Dependencies

Merge after DataBiosphere/terra-ui#5041 is released.

Summary of changes

What

  • Migrate labels to remove saturnAutoCreated label for WORKFLOWS_APP and CROMWELL_RUNNER_APP.

Why

Testing these changes

What to test

Tested in a BEE via the following steps:

  1. Created Azure workspace (WDS, CBAS, and Cromwell apps) using dev code
  2. Verified I see CBAS and Cromwell in the Cloud Envs screen
  3. Created Azure workspace using terra-ui PR code
  4. Verified workspace functionality still works
  5. Verified I do not see Azure apps from (3) in Cloud Envs screen
  6. Deployed this Leo migration PR
  7. Verified I no longer see any Azure apps in the Cloud Envs screen

Who tested and where

  • This change is covered by automated tests
    • NB: Rerun automation tests on this PR by commenting jenkins retest or jenkins multi-test.
  • I validated this change
  • Primary reviewer validated this change
  • I validated this change in the dev environment

@rtitle rtitle marked this pull request as ready for review August 29, 2024 01:26
Copy link

codecov bot commented Aug 29, 2024

Codecov Report

All modified and coverable lines are covered by tests ✅

Project coverage is 74.24%. Comparing base (0f2a5a0) to head (935060f).
Report is 1 commits behind head on develop.

Additional details and impacted files

Impacted file tree graph

@@           Coverage Diff            @@
##           develop    #4772   +/-   ##
========================================
  Coverage    74.24%   74.24%           
========================================
  Files          164      164           
  Lines        14981    14981           
  Branches      1243     1243           
========================================
  Hits         11123    11123           
  Misses        3858     3858           

Continue to review full report in Codecov by Sentry.

Legend - Click here to learn more
Δ = absolute <relative> (impact), ø = not affected, ? = missing data
Powered by Codecov. Last update 0f2a5a0...935060f. Read the comment docs.

@rtitle rtitle merged commit e46acfc into develop Aug 29, 2024
23 of 24 checks passed
@rtitle rtitle deleted the rt-wor-1810 branch August 29, 2024 16:44
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

3 participants