-
Notifications
You must be signed in to change notification settings - Fork 21
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
Authorize to GAR in init scripts #4782
Conversation
Codecov ReportAll modified and coverable lines are covered by tests ✅
Additional details and impacted files@@ Coverage Diff @@
## develop #4782 +/- ##
========================================
Coverage 74.78% 74.78%
========================================
Files 165 165
Lines 14948 14948
Branches 1178 1178
========================================
Hits 11179 11179
Misses 3769 3769
Flags with carried forward coverage won't be shown. Click here to find out more. Continue to review full report in Codecov by Sentry.
|
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
I understand that GCR is being redirected to GAR, but eventually the GCR repos will be fully deprecated, and so it would make sense to me to have Leo explicitly pull from GAR
See https://github.com/DataBiosphere/leonardo/pull/4372/files
We can discuss it more, but this is Leo pulling from GAR, on the cloud console it specifically says that:
The paths are all the same so maybe I'm missing something but I don't see how adding a different regex for GAR makes a difference? |
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Gotcha, I did not realize the paths were similar since they contained gcr
in the string 🤔 In that case I don't know why the Sfkit folks wanted to do that.
This reverts commit bfe0790.
Jira ticket: https://broadworkbench.atlassian.net/browse/IA-4518
Summary of changes
What
Authorize to GAR using
auth configure-docker
rather than custom gcr-enabled docker composeWhy
With switching to GAR instead of GCR, the init scripts that pull our docker images need to be pulling from GAR
Testing these changes
What to test
Who tested and where
jenkins retest
orjenkins multi-test
.