Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Authorize to GAR in init scripts #4782

Merged
merged 11 commits into from
Oct 2, 2024
Merged

Authorize to GAR in init scripts #4782

merged 11 commits into from
Oct 2, 2024

Conversation

lucymcnatt
Copy link
Collaborator

@lucymcnatt lucymcnatt commented Sep 10, 2024

Jira ticket: https://broadworkbench.atlassian.net/browse/IA-4518

Summary of changes

What

Authorize to GAR using auth configure-docker rather than custom gcr-enabled docker compose

Why

With switching to GAR instead of GCR, the init scripts that pull our docker images need to be pulling from GAR

Testing these changes

What to test

Who tested and where

  • This change is covered by automated tests
    • NB: Rerun automation tests on this PR by commenting jenkins retest or jenkins multi-test.
  • I validated this change
  • Primary reviewer validated this change
  • I validated this change in the dev environment

Copy link

codecov bot commented Sep 10, 2024

Codecov Report

All modified and coverable lines are covered by tests ✅

Project coverage is 74.78%. Comparing base (10af4b4) to head (87ddd6c).
Report is 2 commits behind head on develop.

Additional details and impacted files

Impacted file tree graph

@@           Coverage Diff            @@
##           develop    #4782   +/-   ##
========================================
  Coverage    74.78%   74.78%           
========================================
  Files          165      165           
  Lines        14948    14948           
  Branches      1178     1178           
========================================
  Hits         11179    11179           
  Misses        3769     3769           
Flag Coverage Δ
74.78% <ø> (ø)

Flags with carried forward coverage won't be shown. Click here to find out more.


Continue to review full report in Codecov by Sentry.

Legend - Click here to learn more
Δ = absolute <relative> (impact), ø = not affected, ? = missing data
Powered by Codecov. Last update 10af4b4...87ddd6c. Read the comment docs.

Copy link
Collaborator

@LizBaldo LizBaldo left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

I understand that GCR is being redirected to GAR, but eventually the GCR repos will be fully deprecated, and so it would make sense to me to have Leo explicitly pull from GAR

See https://github.com/DataBiosphere/leonardo/pull/4372/files

@lucymcnatt
Copy link
Collaborator Author

lucymcnatt commented Sep 11, 2024

We can discuss it more, but this is Leo pulling from GAR, on the cloud console it specifically says that:

All "*gcr.io" traffic is routed to Artifact Registry.

The paths are all the same so maybe I'm missing something but I don't see how adding a different regex for GAR makes a difference?

Copy link
Collaborator

@LizBaldo LizBaldo left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Gotcha, I did not realize the paths were similar since they contained gcr in the string 🤔 In that case I don't know why the Sfkit folks wanted to do that.

@lucymcnatt lucymcnatt merged commit bfe0790 into develop Oct 2, 2024
23 checks passed
@lucymcnatt lucymcnatt deleted the IA-4518-gcr-gar branch October 2, 2024 15:33
jgainerdewar added a commit that referenced this pull request Oct 17, 2024
jgainerdewar pushed a commit that referenced this pull request Oct 18, 2024
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

3 participants