Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Update changelog.txt related to PR #1332 #1336

Merged
merged 1 commit into from
Nov 12, 2024
Merged

Conversation

nickthetinker
Copy link
Contributor

Added line to changelog related to PR #1332

  • gui/quickfort: fix build mode evluation rules to allow placement of various furniture and constructions on tiles with stair shapes or without orthagonal floor.

Added line to changelog related to PR DFHack#1332
- `gui/quickfort`: fix build mode evluation rules to allow placement of various furniture and constructions on tiles with stair shapes or without orthagonal floor.
@myk002
Copy link
Member

myk002 commented Nov 12, 2024

is there any reason this change is not part of #1332?

@nickthetinker
Copy link
Contributor Author

nickthetinker commented Nov 12, 2024 via email

@myk002
Copy link
Member

myk002 commented Nov 12, 2024

I can merge this commit over to keep them together. Normally, you'd continue adding commits to a PR as it goes through the review process.

@nickthetinker
Copy link
Contributor Author

Thanks. I'm still learning Github's ropes.

@myk002
Copy link
Member

myk002 commented Nov 12, 2024

ooh, nevermind, you started a PR from your master branch. That will make things a bit difficult. No worries, though! I'll get it fixed up in a separate PR.

@myk002
Copy link
Member

myk002 commented Nov 12, 2024

I merged your commits into a branch in #1337

In general, things go a bit smoother if you submit PRs from a non-master branch on your fork. We have some guidelines that might help documented here: https://docs.dfhack.org/en/stable/docs/dev/Contributing.html

@myk002 myk002 merged commit 6530ba7 into DFHack:master Nov 12, 2024
1 check passed
@myk002
Copy link
Member

myk002 commented Nov 12, 2024

ok, I merged everything as a group. Your master branch may need to get reconciled with upstream now (when you submit PRs from a non-master branch, you can just delete them afterwards, but it's important to keep your master branch clean and identical to upstream)

@nickthetinker
Copy link
Contributor Author

nickthetinker commented Nov 12, 2024 via email

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

2 participants