Fix blueprinted constructions over stairs #1332
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
related to issue #5012 Quickfort blueprints can't place bridges over stairs The previous code is more restrictive than vanilla UI. In-game, bridges may be placed in any supported position with a walkable, adjacent tile, including over any kind of stair. In-game, floor hatches, grates, and bars do not require an adjacent floor for placement. Initially I thought these changes may be too simple to be correct, but upon further study and testing, I can find no issues. These changes are in keeping with the 'mission statement' from the original dev found in the top comment of the build.ua file: "In general, we enforce the same rules as the in-game UI for allowed placement of buildings (e.g. beds have to be inside, doors have to be adjacent to a wall, etc.). A notable exception is that we allow constructions and machine components to be designated regardless of whether they are reachable or currently supported. This allows the user to designate an entire floor of an above-ground building or an entire power system without micromanagement."
|
Did you also test to ensure the new logic is correct for other buildings that use Nevermind: I found the discussion in the associated issue. Reading there |
|
Those buildings have the same in-game requirements, so they should be
exactly the same in effect.
However, I will create a blueprint for their testing, and execute it this
evening, just to be sure that they still build in QF and that the tasks can
be done in-game from QF orders.
…-Nick
On Sun, Nov 10, 2024 at 11:38 AM Myk ***@***.***> wrote:
Did you also test to ensure the new logic is correct for *other*
buildings that use is_tile_coverable -- that is, floor hatches, floor
grates, and floor bars?
—
Reply to this email directly, view it on GitHub
<#1332 (comment)>, or
unsubscribe
<https://github.com/notifications/unsubscribe-auth/BMTADOEV4OJPILUCIE4IJDTZ76K2VAVCNFSM6AAAAABRI6BA3GVHI2DSMVQWIX3LMV43OSLTON2WKQ3PNVWWK3TUHMZDINRWHAZDCMBSG4>
.
You are receiving this because you authored the thread.Message ID:
***@***.***>
|
|
Testing is complete.
Floor Grate, Floor Bars, Floor Hatch, and Retracting Bridge are all
buildable on up, down, and updown stairs as intended.
Everything behaves the same whether building in QF or in-game.
Anchored, raising bridges are not installable without a supporting floor or
up-stair or ramp.
Not sure what else to test. Everything looks good.
…-Nick
On Mon, Nov 11, 2024 at 6:55 AM Nick Shapter ***@***.***> wrote:
Those buildings have the same in-game requirements, so they should be
exactly the same in effect.
However, I will create a blueprint for their testing, and execute it this
evening, just to be sure that they still build in QF and that the tasks can
be done in-game from QF orders.
-Nick
On Sun, Nov 10, 2024 at 11:38 AM Myk ***@***.***> wrote:
> Did you also test to ensure the new logic is correct for *other*
> buildings that use is_tile_coverable -- that is, floor hatches, floor
> grates, and floor bars?
>
> —
> Reply to this email directly, view it on GitHub
> <#1332 (comment)>,
> or unsubscribe
> <https://github.com/notifications/unsubscribe-auth/BMTADOEV4OJPILUCIE4IJDTZ76K2VAVCNFSM6AAAAABRI6BA3GVHI2DSMVQWIX3LMV43OSLTON2WKQ3PNVWWK3TUHMZDINRWHAZDCMBSG4>
> .
> You are receiving this because you authored the thread.Message ID:
> ***@***.***>
>
|
myk002
reviewed
Nov 12, 2024
There was a problem hiding this comment.
thank you for testing thoroughly. Getting these rules right is tricky.
Could you add a line about what has been fixed to changelog.txt? https://github.com/DFHack/scripts/blob/master/changelog.txt#L35
nickthetinker
added a commit
to nickthetinker/scripts
that referenced
this pull request
Nov 12, 2024
Added line to changelog related to PR DFHack#1332 - `gui/quickfort`: fix build mode evluation rules to allow placement of various furniture and constructions on tiles with stair shapes or without orthagonal floor.
|
Done.
PR #1336
…On Mon, Nov 11, 2024 at 7:20 PM Myk ***@***.***> wrote:
***@***.**** commented on this pull request.
thank you for testing thoroughly. Getting these rules right is tricky.
Could you add a line about what has been fixed to changelog.txt?
https://github.com/DFHack/scripts/blob/master/changelog.txt#L35
—
Reply to this email directly, view it on GitHub
<#1332 (review)>,
or unsubscribe
<https://github.com/notifications/unsubscribe-auth/BMTADOENJZZZLRICOVQA6HD2AFJUXAVCNFSM6AAAAABRI6BA3GVHI2DSMVQWIX3LMV43YUDVNRWFEZLROVSXG5CSMV3GSZLXHMZDIMRYGQYDGMJYGQ>
.
You are receiving this because you authored the thread.Message ID:
***@***.***>
|
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Fixes: DFHack/dfhack#5012
Quickfort blueprints can't place bridges over stairs
The previous code is more restrictive than vanilla UI.
In-game, bridges may be placed in any supported position with a walkable, adjacent tile, including over any kind of stair. In-game, floor hatches, grates, and bars do not require an adjacent floor for placement.
Initially I thought these changes may be too simple to be correct, but upon further study and testing, I can find no issues.
These changes are in keeping with the 'mission statement' from the original dev found in the top comment of the build.ua file: "In general, we enforce the same rules as the in-game UI for allowed placement of buildings (e.g. beds have to be inside, doors have to be adjacent to a wall, etc.). A notable exception is that we allow constructions and machine components to be designated regardless of whether they are reachable or currently supported. This allows the user to designate an entire floor of an above-ground building or an entire power system without micromanagement."