-
Notifications
You must be signed in to change notification settings - Fork 198
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
Add a suffocation gui overlay as a module - ticks left until death #1174
Merged
+62
−0
Merged
Changes from 5 commits
Commits
Show all changes
9 commits
Select commit
Hold shift + click to select a range
a3f9bff
Add a suffocation overlay as a module, displaying how many ticks left…
Crystalwarrior 5e3dc4c
Add bleeding status effect as well (might need to rename script/branch)
Crystalwarrior ca409af
Fix errors
Crystalwarrior 87abf11
Merge branch 'master' into drowning-overlay
Crystalwarrior a884ee9
Merge drowncheck into gui/notify as suggested
Crystalwarrior 101819a
Merge branch 'master' into drowning-overlay
Crystalwarrior d727be2
refactor common logic into a generic get_bar function
Crystalwarrior 5c21490
Fix colors
Crystalwarrior 37b1483
Revert changes to notify.lua, instead adopting the `critical=true` me…
Crystalwarrior File filter
Filter by extension
Conversations
Failed to load comments.
Loading
Jump to
Jump to file
Failed to load files.
Loading
Diff view
Diff view
There are no files selected for viewing
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
this runs on every call to
plugin_onupdate
, which is way too often. is 5 seconds (or even the default 10) too slow for adventure mode?There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
moreover, the same notification overlay will never be in both dwarfmode and adventure mode. mode-specific logic should be in the specialized subclasses below
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
I dunno how to refactor this because something as important as your suffocation bar needs to be delivered to the player as swiftly as possible. It's especially relevant for swimming.
Perhaps it should only be updated every tick? However there's no existing logic allowing it to be updated every tick currently.
Also, what specialized subclasses do you mean? They can't affect the frequency of updating of the overlay, can they?
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
I meant
DwarfNotifyOverlay
andAdvNotifyOverlay
below, but I think this will take some more work in the frameworkFor now, could you revert changes to this file and instead set
critical=true
on the two notification types innotifications.lua
?There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
how's this? https://github.com/DFHack/scripts/pull/1222/files