Add a suffocation gui overlay as a module - ticks left until death #1174
Conversation
… until you suffocating to death
gui/notify.lua
Outdated
| @@ -64,6 +65,11 @@ end | |||
| function NotifyOverlay:overlay_onupdate() | |||
| local choices = {} | |||
| local is_adv = dfhack.world.isAdventureMode() | |||
| if is_adv then | |||
| self.overlay_onupdate_max_freq_seconds=0 | |||
There was a problem hiding this comment.
this runs on every call to plugin_onupdate, which is way too often. is 5 seconds (or even the default 10) too slow for adventure mode?
There was a problem hiding this comment.
moreover, the same notification overlay will never be in both dwarfmode and adventure mode. mode-specific logic should be in the specialized subclasses below
There was a problem hiding this comment.
I dunno how to refactor this because something as important as your suffocation bar needs to be delivered to the player as swiftly as possible. It's especially relevant for swimming.
Perhaps it should only be updated every tick? However there's no existing logic allowing it to be updated every tick currently.
Also, what specialized subclasses do you mean? They can't affect the frequency of updating of the overlay, can they?
There was a problem hiding this comment.
Also, what specialized subclasses do you mean?
I meant DwarfNotifyOverlay and AdvNotifyOverlay below, but I think this will take some more work in the framework
For now, could you revert changes to this file and instead set critical=true on the two notification types in notifications.lua?
There was a problem hiding this comment.
No description provided.