Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

data identity changes for stl-variant in 50.12 #4092

Merged
merged 1 commit into from
Dec 11, 2023

Conversation

ab9rf
Copy link
Member

@ab9rf ab9rf commented Dec 11, 2023

this is arguably a better approach for the change in #4090

@ab9rf ab9rf mentioned this pull request Dec 11, 2023
Copy link
Member

@lethosor lethosor left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

So this is basically letting the preprocessor split arguments by commas, then joining them with __VA_ARGS__.

I agree it looks cleaner. Haven't tested.

@myk002 myk002 merged commit 7bb3b48 into DFHack:develop Dec 11, 2023
14 checks passed
@ab9rf
Copy link
Member Author

ab9rf commented Dec 11, 2023

So this is basically letting the preprocessor split arguments by commas, then joining them with __VA_ARGS__.

actually think that __VA_ARGS__ bypasses splitting entirely, but that's a compiler implementation detail that frankly i don't care about here. __VA_ARGS__ and the ... meta-argument in macros have been in the standard since C++11, and all of the compilers we care about implement it in the standard way

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

3 participants