add identity for variant #4090
Merged
add identity for variant #4090
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
ab9rf
reviewed
Dec 10, 2023
| @@ -49,7 +49,9 @@ namespace df { | |||
| STL_OPAQUE_IDENTITY_TRAITS(mutex); | |||
| STL_OPAQUE_IDENTITY_TRAITS(future<void>); | |||
| STL_OPAQUE_IDENTITY_TRAITS(function<void()>); | |||
| STL_OPAQUE_IDENTITY_TRAITS(optional<std::function<void()> >); | |||
| STL_OPAQUE_IDENTITY_TRAITS(optional<void_function>); | |||
| OPAQUE_IDENTITY_TRAITS_NAME(std::variant<std::string COMMA void_function>, | |||
There was a problem hiding this comment.
there's a betetr way to do this using __VA_ARGS__. i have it in a local test branch, will dig out and PR expeditiously
There was a problem hiding this comment.
Thanks. I was pretty unhappy with how this looked
There was a problem hiding this comment.
might want to cherry-pick bef0cde, which is on my 5012-testing-1 branch (feel free to omit the library/xml branch change)
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
I plan to merge this expediently to unbreak the build, but post-merge review would be welcome