fix(sensor_download_info): use v2 override for new endpoint #520
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
To maintain backwards compatability with FalconPy, we take advantage of the override feature that allows us to use the new sensors/combined/installers/v2 endpoint. This means we can now pass in architectures as a filter. This also updates the limit to ensure users know the default limit is set to 100.
redhatrises
previously approved these changes
May 21, 2024
This particular endpoint doesn't provide an offset which is strange since the default limit is 100 and if you have more than that you wouldn't know without passing in a larger offset.
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
To maintain backwards compatability with FalconPy, we take advantage of the override feature that allows us to use the new sensors/combined/installers/v2 endpoint. This means we can now pass in architectures as a filter.
This also updates the limit to ensure users know the default limit is set to 100.
Closes #488