Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

fix(falcon_install): pass in the appropriate filter for architecture #521

Merged
merged 3 commits into from
May 21, 2024
Merged

fix(falcon_install): pass in the appropriate filter for architecture #521

merged 3 commits into from
May 21, 2024

Conversation

carlosmmatos
Copy link
Contributor

Closes #489

This PR updates the falcon_install role to take advantage of the new #520 V2 API endpoint updates that allows us to query an architecture now.

Instead of doing the following to only get x86_64 installers:

x86_64: "+os_version:!~'arm64'+os_version:!~'zLinux'"

We can do this:

x86_64: "+architectures:'x86_64'"

@carlosmmatos carlosmmatos added the bugfixes Bug fixes or minor enhancements label May 21, 2024
@carlosmmatos carlosmmatos added this to the 4.5.1 milestone May 21, 2024
@carlosmmatos carlosmmatos requested a review from redhatrises May 21, 2024 13:56
@carlosmmatos carlosmmatos self-assigned this May 21, 2024
@carlosmmatos carlosmmatos added the ok-to-test Run tests label May 21, 2024
@carlosmmatos carlosmmatos merged commit bee4d05 into CrowdStrike:main May 21, 2024
36 of 38 checks passed
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@redhatrises redhatrises redhatrises approved these changes

Assignees

@carlosmmatos carlosmmatos

Labels
bugfixes Bug fixes or minor enhancements ok-to-test Run tests
Projects
None yet
Milestone
4.5.1
Development

Successfully merging this pull request may close these issues.

update falcon_install role to take advantage of v2 sensor_download module
2 participants
@carlosmmatos @redhatrises