Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

fix MRO issue in the class Asset #192

Closed
wants to merge 1 commit into from
Closed

Conversation

llin17
Copy link
Contributor

@llin17 llin17 commented Jul 13, 2023

This pull request aims to resolve the MRO issue described in #191.

@antoinejeannot
Copy link
Contributor

Actually, the MRO issue belongs to the MyModel class, especially its parents class which are called in the wrong order.
It should be:

class MyModel(MyMixin, MyClass):

instead of the other way around:

class MyModel(MyClass, MyMixin):

With this, no need to fix anything in Asset, and the tests pass as well!

I am closing the PR (that has been opened too long), but the discussions remains of course open in the Issues section :)
However, your PR / issue highlighted an actual MRO issue in the tensorflow models section from core!
I will open a PR to fix it right away.

Thanks!

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

2 participants