Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

MRO is not respected in the class Asset #191

Open
llin17 opened this issue Jul 13, 2023 · 1 comment
Open

MRO is not respected in the class Asset #191

llin17 opened this issue Jul 13, 2023 · 1 comment

Comments

@llin17
Copy link
Contributor

llin17 commented Jul 13, 2023

The current code suffers from a method resolution order (MRO) issue. In the Asset class, the __init__ method does not call super().__init__(), resulting in an incorrect MRO. This omission prevents the proper initialization of the superclass, leading to potential errors or undesired behavior when inheriting from Asset. To ensure that the MRO is respected and the superclass is initialized correctly, it is necessary to include super().__init__() in the __init__ method of the Asset class.

@antoinejeannot
Copy link
Contributor

See discussion in #192

@antoinejeannot antoinejeannot added question Further information is requested discussion and removed question Further information is requested labels Oct 11, 2023
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Projects
None yet
Development

No branches or pull requests

2 participants