-
Notifications
You must be signed in to change notification settings - Fork 33
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
Add API validation step for OpenAI in Settings #2265
Conversation
Bundle Size Diff
|
Plugin build for d2ed9e4 is ready 🛎️!
|
E2E TestsPlaywright Test Status: Performance ResultsserverResponse: 245.8, firstPaint: 156.6, domContentLoaded: 1615.95, loaded: 1616.75, firstContentfulPaint: 3602, firstBlock: 7056.2, type: 14.13, minType: 12.21, maxType: 17.93, typeContainer: 9.14, minTypeContainer: 7.83, maxTypeContainer: 11.56, focus: 36.13, minFocus: 31.09, maxFocus: 45.26, inserterOpen: 26.15, minInserterOpen: 22.87, maxInserterOpen: 33.11, inserterSearch: 0.77, minInserterSearch: 0.63, maxInserterSearch: 1.04, inserterHover: 3.39, minInserterHover: 2.69, maxInserterHover: 4.46, listViewOpen: 154.65, minListViewOpen: 138.85, maxListViewOpen: 188.55 |
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Everything looked really good! Just a few comments, but nothing really major. 🥳
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Just need to fix the json_decode
edge case and we're good 🥳
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Merge all the commits together and add the feat:
in the commit message and we're good to go!
🎉 This PR is included in version 3.0.0 🎉 The release is available on GitHub release Your semantic-release bot 📦🚀 |
Closes https://github.com/Codeinwp/otter-internals/issues/191
Summary
The PR adds a validation step to OpenAI API insertion by making an example request, thus making sure it also has the required capabilities for making a Chat Completion request.
Screenshots
Test instructions
Checklist before the final review