-
Notifications
You must be signed in to change notification settings - Fork 33
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
feat: use editable actions for AI Toolbar #2293
Conversation
Bundle Size Diff
|
Plugin build for e7edad1 is ready 🛎️!
|
E2E TestsPlaywright Test Status: Performance ResultsserverResponse: 245.7, firstPaint: 153.1, domContentLoaded: 1610.85, loaded: 1611.55, firstContentfulPaint: 3670.15, firstBlock: 8152.7, type: 14.21, minType: 12.89, maxType: 17.18, typeContainer: 9.72, minTypeContainer: 7.7, maxTypeContainer: 13.49, focus: 36.06, minFocus: 32.58, maxFocus: 46.62, inserterOpen: 23.37, minInserterOpen: 21.07, maxInserterOpen: 27.32, inserterSearch: 0.76, minInserterSearch: 0.62, maxInserterSearch: 0.9, inserterHover: 4.22, minInserterHover: 2.81, maxInserterHover: 16.52, listViewOpen: 152.92, minListViewOpen: 143.17, maxListViewOpen: 167.25 |
a403a6d
to
f1ae012
Compare
76199a0
to
07ec3af
Compare
07ec3af
to
26ffe59
Compare
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Looks good! I had one small thing around ternary operators in JS.
You should also at least merge the chore
commit in the feat
commit. If you want to keep the fix
commit, you should have a test to show what you're fixing.
26ffe59
to
6b2b07a
Compare
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Thanks for doing the ternary operator change! 🙌
Just missing what I mentioned about commits in the last review:
You should also at least merge the
chore
commit in thefeat
commit. If you want to keep thefix
commit, you should have a test to show what you're fixing.
The other option is to just merge everything into the feat
commit. A fix
commit should almost always have a test because you're fixing something. There are a few exceptions, but this doesn't seem like one to me.
@carlalexander, the order is acceptable. I want the third commit to be separated as it is. I will change the name of the four commits to be more explicit than is about the three commit. UPDATE: let's leave like this. The rebase is not working to well and I think I need to make new clean branch to make the change |
I think it might be the merge commits. Usually, it's better to rebase the PR branch. Let's go ahead with this and we'll work more on this next time 🥳 |
🎉 This PR is included in version 3.0.0 🎉 The release is available on GitHub release Your semantic-release bot 📦🚀 |
Closes https://github.com/Codeinwp/otter-internals/issues/215
Summary
Added the toolbar actions as editable custom prompts.
Technical changes:
wp_option
entry to save the custom actionsScreenshots
2024-07-30_12-55-01.mp4
2024-07-30_14-47-31.mp4
Test instructions
Note
Make sure to have an OpenAI API Key
Checklist before the final review