Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Improve Marketing Integration info & bug fix #1868

Merged
merged 10 commits into from
Nov 2, 2023

Conversation

Soare-Robert-Daniel
Copy link
Contributor

@Soare-Robert-Daniel Soare-Robert-Daniel commented Sep 15, 2023

Closes #1290

Summary

πŸ–ŠοΈ Improved the Marketing Action explanations.
πŸ› Fixed a bug related to the default action.

Screenshots

image

image

image


Test instructions

⚠️ This is tied to the development branch. When next will be merged, I will update this.

⚠️ You will need a Mailchimp and Sendinblue account.

  1. Make a Form
  2. Fill in the Marketing integration options.
  3. Ensure that they work as expected.

Checklist before the final review

  • Included E2E or unit tests for the changes in this PR.
  • Visual elements are not affected by independent changes.
  • It is at least compatible with the minimum WordPress version.
  • It loads additional script in frontend only if it is required.
  • Does not impact the Core Web Vitals.
  • In case of deprecation, old blocks are safely migrated.
  • It is usable in Widgets and FSE.
  • Copy/Paste is working if the attributes are modified.
  • PR is following the best practices

@Soare-Robert-Daniel Soare-Robert-Daniel self-assigned this Sep 15, 2023
@Soare-Robert-Daniel Soare-Robert-Daniel added the pr-checklist-skip Allow this Pull Request to skip checklist. label Sep 15, 2023
@Soare-Robert-Daniel Soare-Robert-Daniel marked this pull request as ready for review September 19, 2023 08:19
@pirate-bot
Copy link
Contributor

pirate-bot commented Sep 19, 2023

Bundle Size Diff

Package Old Size New Size Diff
Animations 275.01 KB 275.01 KB 0 B (0.00%)
Blocks 1.47 MB 1.47 MB 686 B (0.04%)
CSS 89.3 KB 89.3 KB 0 B (0.00%)
Dashboard 131.28 KB 131.28 KB 0 B (0.00%)
Export Import 87.21 KB 87.21 KB 0 B (0.00%)
Pro 346.54 KB 346.61 KB 69 B (0.02%)

@pirate-bot
Copy link
Contributor

pirate-bot commented Sep 19, 2023

Plugin build for 07f883b is ready πŸ›ŽοΈ!

@pirate-bot
Copy link
Contributor

pirate-bot commented Sep 19, 2023

E2E Summary

Typing

Test Average Time (ms) Standard Deviation (ms) Median Time (ms) Quantile for soft limit (%) Quantile for hard limit (%)
Typing 95.62 23.99 89.04 0 (60ms) 31.58 (80ms)
Values above 60ms "0 - 67.71, 1 - 109.54, 2 - 89.04, 3 - 69.86, 4 - 80.56, 5 - 126.30, 6 - 74.35, 7 - 103.34, 8 - 105.73, 9 - 81.80, 10 - 83.75, 11 - 77.67, 12 - 103.93, 13 - 76.84, 14 - 124.04, 15 - 89.71, 16 - 131.96, 17 - 153.94, 18 - 66.78"

@pirate-bot pirate-bot added the pr-checklist-complete The Pull Request checklist is complete. (automatic label) label Sep 20, 2023
@Soare-Robert-Daniel
Copy link
Contributor Author

πŸ”§ The message is now changed and also added a new message to inform the user that they might lose some data with the combination of Email saving and Subscriber Only combo.

ℹ️ This new message will also serve as a small upsell on the Database Pro option.

image

@irinelenache
Copy link
Contributor

@Soare-Robert-Daniel From what i understand, if i use Email Only as save location and Subscribe only as submit action, i shouln't receive any email and the contact should be added in the marketing integration tool (i used Mailchimp). While testing this behaviour, i received the email and the contact wasn't added to the marketing integration tool, so it's not working on my end.
Please let me know if i misunderstood anything πŸ™

Can be checked here:

URL: https://otter-stuff.vertisite.cloud/15c42-web-agency-gb-contact-us/
Username: kikevepiwu4475
Password: nAfE6HGJrILlpUc3wOeu

@Soare-Robert-Daniel
Copy link
Contributor Author

The problem was that when you update the page via Update button, the Integration settings will disappear thus the error reported. When implementing the deferred save, the mechanism replace the entire value, the change in form did not account for the information in the old value, thus the loss of information.

@irinelenache, I updated your testing instance to the latest build.

@irinelenache
Copy link
Contributor

@Soare-Robert-Daniel

  • After the loading finishes in the Form options and Marketing integration tabs, it takes another ~20 seconds for the data to be visible there https://vertis.d.pr/v/lhhFDX
  • The contacts are not added to Mailchimp when the form is submitted. I also tried using the Test service button which doesn't give any error but no new contact is added there

@Soare-Robert-Daniel
Copy link
Contributor Author

  • After the loading finishes in the Form options and Marketing integration tabs, it takes another ~20 seconds for the data to be visible there https://vertis.d.pr/v/lhhFDX

This depends on the WP instance until it gest the options.

  • The contacts are not added to Mailchimp when the form is submitted. I also tried using the Test service button which doesn't give any error but no new contact is added there

This should be working.


@irinelenache,if you can provide a recording in Slack with how you set until test might be helpful πŸ™

@irinelenache
Copy link
Contributor

@Soare-Robert-Daniel Tested again and now everything works as expected πŸ‘

@HardeepAsrani HardeepAsrani merged commit 27bcbe8 into development Nov 2, 2023
11 checks passed
@HardeepAsrani HardeepAsrani deleted the feat/form-marketing-ux branch November 2, 2023 06:09
@AndreeaCristinaRadacina
Copy link

hey @Soare-Robert-Daniel,

Can you change "news letter" to "newsletter"?
image

@AndreeaCristinaRadacina

Question here:
If I use Database & Email as a save location, it says in the note that I will receive notifications via email.
However, if I also use the "Subscribe Only" as an action, no notification should appear in the email.

As a result, the submissions appear under Form Submissions, and no email is received, which is not the ideal behavior since I was able to select Database & Email.

My suggestion: If Database & Email is selected, the Subscribe Only option should be greyed out.

@AndreeaCristinaRadacina
  • We should replace "Form to" with "Email To", for consistency:
image
  • it says something about third-party consent, but I cannot see any checkbox

@pirate-bot
Copy link
Contributor

πŸŽ‰ This PR is included in version 2.5.0 πŸŽ‰

The release is available on GitHub release

Your semantic-release bot πŸ“¦πŸš€

@pirate-bot pirate-bot added the released Indicate that an issue has been resolved and released in a particular version of the product. label Nov 16, 2023
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
pr-checklist-complete The Pull Request checklist is complete. (automatic label) pr-checklist-skip Allow this Pull Request to skip checklist. released Indicate that an issue has been resolved and released in a particular version of the product.
Projects
None yet
Development

Successfully merging this pull request may close these issues.

Add option to disable email notifications if user has enabled subscription
5 participants