-
Notifications
You must be signed in to change notification settings - Fork 33
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. Weβll occasionally send you account related emails.
Already on GitHub? Sign in to your account
Improve Marketing Integration info & bug fix #1868
Conversation
Bundle Size Diff
|
Plugin build for 07f883b is ready ποΈ!
|
E2E SummaryTyping
Values above 60ms"0 - 67.71, 1 - 109.54, 2 - 89.04, 3 - 69.86, 4 - 80.56, 5 - 126.30, 6 - 74.35, 7 - 103.34, 8 - 105.73, 9 - 81.80, 10 - 83.75, 11 - 77.67, 12 - 103.93, 13 - 76.84, 14 - 124.04, 15 - 89.71, 16 - 131.96, 17 - 153.94, 18 - 66.78" |
@Soare-Robert-Daniel From what i understand, if i use Email Only as save location and Subscribe only as submit action, i shouln't receive any email and the contact should be added in the marketing integration tool (i used Mailchimp). While testing this behaviour, i received the email and the contact wasn't added to the marketing integration tool, so it's not working on my end. Can be checked here:
|
The problem was that when you update the page via Update button, the Integration settings will disappear thus the error reported. When implementing the deferred save, the mechanism replace the entire value, the change in form did not account for the information in the old value, thus the loss of information. @irinelenache, I updated your testing instance to the latest build. |
|
This depends on the WP instance until it gest the options.
This should be working. @irinelenache,if you can provide a recording in Slack with how you set until test might be helpful π |
@Soare-Robert-Daniel Tested again and now everything works as expected π |
hey @Soare-Robert-Daniel, |
Question here: As a result, the submissions appear under Form Submissions, and no email is received, which is not the ideal behavior since I was able to select Database & Email. My suggestion: If Database & Email is selected, the Subscribe Only option should be greyed out. |
π This PR is included in version 2.5.0 π The release is available on GitHub release Your semantic-release bot π¦π |
Closes #1290
Summary
ποΈ Improved the Marketing Action explanations.
π Fixed a bug related to the default action.
Screenshots
Test instructions
development
branch. Whennext
will be merged, I will update this.Checklist before the final review