Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Add option to disable email notifications if user has enabled subscription #1290

Closed
MarinescuLucia opened this issue Oct 21, 2022 · 11 comments · Fixed by #1868
Closed

Add option to disable email notifications if user has enabled subscription #1290

MarinescuLucia opened this issue Oct 21, 2022 · 11 comments · Fixed by #1868
Assignees
Labels
doc-needed This issue requires documentation updates or additions once it has been completed. released Indicate that an issue has been resolved and released in a particular version of the product. Small enhancement A small update that will improve the quality of life in the app small (1-3h) This label is used for issues that can be completed within 3 hours or less.
Milestone

Comments

@MarinescuLucia
Copy link

A user asked if it's possible to disable the email notifications that are sent to the admin when a person subscribes to the form from the maintenance/coming soon page. Maybe we could add an option to be able to do this.

As an alternative solution, I think we could create a doc explaining how to achieve this with custom code.

Suggested here.

@girishpanchal30
Copy link
Contributor

Hello @MarinescuLucia,

I can't find a filter to skip the admin notification, it appears that the otter block plugin handles admin notifications.

@arinaturcu @HardeepAsrani Do you have any idea to skip the admin notification?

Thanks

@HardeepAsrani
Copy link
Member

@girishpanchal30 No, we always send email as we don't store them anywhere, just send them straight away to the user. It makes sense to have them if the user is using the form only for a subscription. Will move this ticket to Otter repository.

Thanks @MarinescuLucia for reporting this.

@HardeepAsrani HardeepAsrani transferred this issue from Codeinwp/wp-maintenance-mode Oct 27, 2022
@HardeepAsrani HardeepAsrani changed the title Add option to disable email notifications Add option to disable email notifications if user has enabled subscription Oct 27, 2022
@HardeepAsrani
Copy link
Member

A note when working on this: user should be made aware that we don't store emails anywhere so only enable it if they are using it for subscription and don't want to get notified.

@HardeepAsrani
Copy link
Member

@girishpanchal30 If needed, one can disable it site-wide using https://github.com/Codeinwp/otter-blocks/blob/master/inc/server/class-form-server.php#L110 but that's not ideal.

@HardeepAsrani HardeepAsrani added the Small enhancement A small update that will improve the quality of life in the app label Oct 27, 2022
@HardeepAsrani HardeepAsrani added this to the 2.x milestone Oct 27, 2022
@HardeepAsrani
Copy link
Member

@Soare-Robert-Daniel We can put this on hold for now and we can approach it later when we work on the admin dashboard with mails.

@HardeepAsrani
Copy link
Member

@arinaturcu I think you can group this in with #1463, maybe some option in Form Block to select if they want notification or storing (or both), with both being enabled by default.

@HardeepAsrani HardeepAsrani modified the milestones: 2.x, 2.2.3, 2.3 Feb 3, 2023
@arinaturcu arinaturcu added the medium (1d) - This label is used for issues that can be completed within 1 day or less. label Feb 12, 2023
@HardeepAsrani HardeepAsrani modified the milestones: 2.3, 2.x May 22, 2023
@HardeepAsrani HardeepAsrani removed the medium (1d) - This label is used for issues that can be completed within 1 day or less. label Aug 31, 2023
@Soare-Robert-Daniel
Copy link
Contributor

Since we now have Database option as a saving location, we can close this. @HardeepAsrani

@HardeepAsrani
Copy link
Member

@Soare-Robert-Daniel This was related to a free user who was using the form for just subscription users to newsletter and not wanting to get the alerts.

@Soare-Robert-Daniel
Copy link
Contributor

So, should we add a special button for it? Like a toggle for notifications?

@HardeepAsrani
Copy link
Member

@Soare-Robert-Daniel One option to not save it anywhere in the drop-down, with selecting it showing a help text and explaining the situation where it can be helpful.

@HardeepAsrani HardeepAsrani added the doc-needed This issue requires documentation updates or additions once it has been completed. label Sep 13, 2023
@Soare-Robert-Daniel Soare-Robert-Daniel added the small (1-3h) This label is used for issues that can be completed within 3 hours or less. label Sep 14, 2023
@Soare-Robert-Daniel Soare-Robert-Daniel linked a pull request Sep 15, 2023 that will close this issue
9 tasks
@pirate-bot
Copy link
Contributor

🎉 This issue has been resolved in version 2.5.0 🎉

The release is available on GitHub release

Your semantic-release bot 📦🚀

@pirate-bot pirate-bot added the released Indicate that an issue has been resolved and released in a particular version of the product. label Nov 16, 2023
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
doc-needed This issue requires documentation updates or additions once it has been completed. released Indicate that an issue has been resolved and released in a particular version of the product. Small enhancement A small update that will improve the quality of life in the app small (1-3h) This label is used for issues that can be completed within 3 hours or less.
Projects
None yet
Development

Successfully merging a pull request may close this issue.

6 participants