Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Improve Otter Dashboard UX #1866

Merged
merged 2 commits into from
Sep 25, 2023
Merged

Improve Otter Dashboard UX #1866

merged 2 commits into from
Sep 25, 2023

Conversation

Soare-Robert-Daniel
Copy link
Contributor

@Soare-Robert-Daniel Soare-Robert-Daniel commented Sep 13, 2023

Closes #1842

Summary

πŸ”₯ Improved the Dashboard experience

  • Individual locking instead of Global. πŸ”’
  • Rollback in case of errors. βͺ

While developing this, the following issues have been found:

  • [Fixed] The page will crash if you are offline and toggle one option. This is caused by an unhandled undefined value on the error response.
  • [To be avoided] Passing the updateOption of the custom hook useSettings to component children will make all states update of the children unavailable when called together with updateOption.

Screenshots

2023-09-13.12-47-21.mp4

Test instructions

Ensure enabling/disabling the options from the Otter Page Dashboard tab works fine. Other tabs, like Integration, are not affected by those changes.


Checklist before the final review

  • Included E2E or unit tests for the changes in this PR.
  • Visual elements are not affected by independent changes.
  • It is at least compatible with the minimum WordPress version.
  • It loads additional script in frontend only if it is required.
  • Does not impact the Core Web Vitals.
  • In case of deprecation, old blocks are safely migrated.
  • It is usable in Widgets and FSE.
  • Copy/Paste is working if the attributes are modified.
  • PR is following the best practices

@Soare-Robert-Daniel Soare-Robert-Daniel self-assigned this Sep 13, 2023
@Soare-Robert-Daniel Soare-Robert-Daniel added the pr-checklist-skip Allow this Pull Request to skip checklist. label Sep 13, 2023
@Soare-Robert-Daniel Soare-Robert-Daniel marked this pull request as ready for review September 13, 2023 09:49
@pirate-bot
Copy link
Contributor

pirate-bot commented Sep 13, 2023

Bundle Size Diff

Package Old Size New Size Diff
Animations 274.83 KB 274.83 KB 0 B (0.00%)
Blocks 1.47 MB 1.47 MB 28 B (0.00%)
CSS 89.3 KB 89.3 KB 0 B (0.00%)
Dashboard 127.66 KB 129.72 KB 2.06 KB (1.62%)
Export Import 87.19 KB 87.19 KB 0 B (0.00%)
Pro 346.73 KB 346.75 KB 28 B (0.01%)

@pirate-bot
Copy link
Contributor

pirate-bot commented Sep 13, 2023

Plugin build for 73ef096 is ready πŸ›ŽοΈ!

@pirate-bot
Copy link
Contributor

E2E Summary

Typing

Test Average Time (ms) Standard Deviation (ms) Median Time (ms) Quantile for soft limit (%) Quantile for hard limit (%)
Typing 86.31 16.46 82.08 0 (60ms) 42.11 (80ms)
Values above 60ms "0 - 83.92, 1 - 107.47, 2 - 115.81, 3 - 71.51, 4 - 85.56, 5 - 72.92, 6 - 79.81, 7 - 84.42, 8 - 139.58, 9 - 76.67, 10 - 76.91, 11 - 82.02, 12 - 83.58, 13 - 75.77, 14 - 85.76, 15 - 82.24, 16 - 74.63, 17 - 82.08, 18 - 79.27"

@Soare-Robert-Daniel Soare-Robert-Daniel changed the title Fix/dashboard options Improve Otter Dashboard UX Sep 14, 2023
@pirate-bot pirate-bot added the pr-checklist-complete The Pull Request checklist is complete. (automatic label) label Sep 14, 2023
@rodica-andronache
Copy link

@Soare-Robert-Daniel everything's working well πŸ‘

@HardeepAsrani HardeepAsrani merged commit 2b0ba62 into development Sep 25, 2023
10 of 11 checks passed
@HardeepAsrani HardeepAsrani deleted the fix/dashboard-options branch September 25, 2023 08:27
@pirate-bot
Copy link
Contributor

πŸŽ‰ This PR is included in version 2.4.1 πŸŽ‰

The release is available on GitHub release

Your semantic-release bot πŸ“¦πŸš€

@pirate-bot pirate-bot added the released Indicate that an issue has been resolved and released in a particular version of the product. label Oct 25, 2023
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
pr-checklist-complete The Pull Request checklist is complete. (automatic label) pr-checklist-skip Allow this Pull Request to skip checklist. released Indicate that an issue has been resolved and released in a particular version of the product.
Projects
None yet
Development

Successfully merging this pull request may close these issues.

Decrease the delay when enabling/disabling options in Otter Dashboard
4 participants