generated from CodeYourFuture/Module-Template
-
-
Notifications
You must be signed in to change notification settings - Fork 55
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
London 11 | Pezhman-Azizi | Data-Groups | sprint 3 | Alarm Clock #275
Open
Pezhman-Azizi
wants to merge
3
commits into
CodeYourFuture:main
Choose a base branch
from
Pezhman-Azizi:alarmclock
base: main
Could not load branches
Branch not found: {{ refName }}
Loading
Could not load tags
Nothing to show
Loading
Are you sure you want to change the base?
Some commits from the old base branch may be removed from the timeline,
and old review comments may become outdated.
Open
Changes from all commits
Commits
Show all changes
3 commits
Select commit
Hold shift + click to select a range
File filter
Filter by extension
Conversations
Failed to load comments.
Loading
Jump to
Jump to file
Failed to load files.
Loading
Diff view
Diff view
There are no files selected for viewing
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
| Original file line number | Diff line number | Diff line change |
|---|---|---|
| @@ -1,25 +1,74 @@ | ||
| function setAlarm() {} | ||
| // Variables to keep track of the countdown timer | ||
| let countdownInterval; // This is where we'll store the timer ID | ||
| let remainingTime; // This keeps track of how many seconds are left | ||
|
|
||
| // DO NOT EDIT BELOW HERE | ||
| // This is the alarm sound | ||
| const audio = new Audio("alarmsound.mp3"); | ||
|
|
||
| var audio = new Audio("alarmsound.mp3"); | ||
| /** | ||
| * This function starts the alarm countdown | ||
| */ | ||
| function setAlarm() { | ||
| const input = document.getElementById("alarmSet").value; | ||
| remainingTime = parseInt(input, 10); | ||
|
|
||
| function setup() { | ||
| document.getElementById("set").addEventListener("click", () => { | ||
| setAlarm(); | ||
| }); | ||
| // Check if the user entered a valid number | ||
| if (isNaN(remainingTime) || remainingTime <= 0) { | ||
| alert("Hey, please type a positive number!"); | ||
| return; | ||
| } | ||
|
|
||
| // Show the initial countdown time on the screen | ||
| updateTimeDisplay(remainingTime); | ||
|
|
||
| // Stop any existing countdown | ||
| clearInterval(countdownInterval); | ||
|
|
||
| document.getElementById("stop").addEventListener("click", () => { | ||
| pauseAlarm(); | ||
| }); | ||
| // Start a new countdown that updates every second | ||
| countdownInterval = setInterval(() => { | ||
| remainingTime -= 1; | ||
| updateTimeDisplay(remainingTime); | ||
|
|
||
| // When the timer hits 0, stop it and play the alarm | ||
| if (remainingTime <= 0) { | ||
| clearInterval(countdownInterval); | ||
| playAlarm(); | ||
| } | ||
| }, 1000); | ||
| } | ||
|
|
||
| /** | ||
| * This function updates the countdown on the screen | ||
| * @param {number} seconds - The time left in seconds | ||
| */ | ||
| function updateTimeDisplay(seconds) { | ||
| const minutes = String(Math.floor(seconds / 60)).padStart(2, "0"); | ||
| const secs = String(seconds % 60).padStart(2, "0"); | ||
| document.getElementById("timeRemaining").innerText = `Time Remaining: ${minutes}:${secs}`; | ||
| } | ||
|
|
||
| /** | ||
| * This function plays the alarm sound | ||
| */ | ||
| function playAlarm() { | ||
| audio.play(); | ||
| } | ||
|
|
||
| /** | ||
| * This function stops the alarm and clears the timer | ||
| */ | ||
| function pauseAlarm() { | ||
| audio.pause(); | ||
| clearInterval(countdownInterval); | ||
| } | ||
|
|
||
| /** | ||
| * This function sets up the buttons when the page loads | ||
| */ | ||
| function setup() { | ||
| document.getElementById("set").addEventListener("click", setAlarm); | ||
| document.getElementById("stop").addEventListener("click", pauseAlarm); | ||
| } | ||
|
|
||
| // Run the setup function when the page is fully loaded | ||
| window.onload = setup; |
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Oops, something went wrong.
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Your script has some duplicate code lines, please fix it. It's causing some unexpected behaviour.
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Thanks very much for taking time reviewing my approach. I just removed the duplicated parts to prevent unexpected behaviors.