London 11 | Pezhman-Azizi | Data-Groups | sprint 3 | Alarm Clock #275
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
2- Plays alarm at 00:00 and stops with the button. 3- Basic input validation included.
Installed @testing-library/jest-dom to resolve test errors. Updated and verified the test environment is working smoothly.
KudahShambare
suggested changes
Jan 7, 2025
There was a problem hiding this comment.
Your script has some duplicate code lines, please fix it. It's causing some unexpected behaviour.
There was a problem hiding this comment.
Thanks very much for taking time reviewing my approach. I just removed the duplicated parts to prevent unexpected behaviors.
KudahShambare
added
Reviewed
Pezhman-Azizi
added
Complete
Pezhman-Azizi
added
Complete
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Learners, PR Template
Self checklist
Changelist
This PR adds the core functionality for the alarm clock, including a countdown timer, alarm sound at 00:00, and a stop button to pause the alarm. It also fixes the testing setup by installing the missing @testing-library/jest-dom dependency, ensuring the test environment works correctly.
Questions
Is the way I update the DOM for the countdown timer efficient, or could it be improved? Are there better practices for handling events or updating elements that I might have missed? Does the interaction between the HTML and JavaScript look clean and easy to maintain? Any suggestions to make the DOM-related parts of the project more efficient or user-friendly?