Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

Properly show variant's prefix/suffix in the crafting menu #78904

Merged
merged 2 commits into from
Jan 4, 2025
Merged

Properly show variant's prefix/suffix in the crafting menu #78904

merged 2 commits into from
Jan 4, 2025
+82 −25

Conversation

moxian
Copy link
Contributor

@moxian moxian commented Jan 2, 2025 •
edited
Loading

Summary

Bugfixes "Fixes item prefixes (XL/XS) sometimes not being shown in crafting menu"

Purpose of change

If a recipe has a specific variant and that variant uses XL/XS tags, then the crafting menu would not present the XL/XS. This PR fixes this niche (but annoying) bug.

Describe the solution

Leverage the common tname machinery when determining recipe result name, instead of hackishly reimplementing it partway.

Describe alternatives you've considered

Remove every single xs/xl item (for legal reasons, this is a joke)

Testing

20250101-230753-cataclysm-tiles

+ added some checks to crafting_test.cpp

Additional context

@github-actions github-actions bot added Info / User Interface Game - player communication, menus, etc. Crafting / Construction / Recipes Includes: Uncrafting / Disassembling [C++] Changes (can be) made in C++. Previously named `Code` <Bugfix> This is a fix for a bug (or closes open issue) json-styled JSON lint passed, label assigned by github actions labels Jan 2, 2025
@github-actions github-actions bot added [JSON] Changes (can be) made in JSON Code: Tests Measurement, self-control, statistics, balancing. astyled astyled PR, label is assigned by github actions labels Jan 2, 2025
@moxian moxian marked this pull request as ready for review January 2, 2025 08:18
@github-actions github-actions bot added the BasicBuildPassed This PR builds correctly, label assigned by github actions label Jan 2, 2025
@Maleclypse Maleclypse merged commit 005a9fe into CleverRaven:master Jan 4, 2025
39 of 46 checks passed
@Maleclypse
Copy link
Member

Great fix!

@Brambor Brambor mentioned this pull request Jan 4, 2025
Open
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers
No reviews
Assignees
No one assigned
Labels
astyled astyled PR, label is assigned by github actions BasicBuildPassed This PR builds correctly, label assigned by github actions <Bugfix> This is a fix for a bug (or closes open issue) [C++] Changes (can be) made in C++. Previously named `Code` Code: Tests Measurement, self-control, statistics, balancing. Crafting / Construction / Recipes Includes: Uncrafting / Disassembling Info / User Interface Game - player communication, menus, etc. [JSON] Changes (can be) made in JSON json-styled JSON lint passed, label assigned by github actions
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.

crafting apron: result is XL/XS, the recipe is not
2 participants
@moxian @Maleclypse