Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

item_suffix and item_prefix are not displayed in some menus #72193

Open
Uwuewsky opened this issue Mar 6, 2024 · 7 comments
Open

item_suffix and item_prefix are not displayed in some menus #72193

Uwuewsky opened this issue Mar 6, 2024 · 7 comments
Labels
Info / User Interface Game - player communication, menus, etc. Items: Variants Variants of items (S2 - Confirmed) Bug that's been confirmed to exist

Comments

@Uwuewsky
Copy link
Contributor

Uwuewsky commented Mar 6, 2024

Describe the bug

Prefixes and suffixes presented in #71702 are not displayed in the crafting menu and in dialogue options.

Attach save file

N/A; requires game modification

Steps to reproduce

  1. Add to the end of the data/json/flags.json file:
  {
    "id": "PREFIX_DEBUG",
    "type": "json_flag",
    "item_prefix": "[CUSTOM PREFIX] "
  }
  1. Extend some item (data/json/items/comestibles/dairy.json) with this flag:
  {
    "type": "COMESTIBLE",
    "id": "milk",
    "name": { "str_sp": "milk" },
    ...
    "flags": [ "EATEN_COLD", "PREFIX_DEBUG" ],
    ...
  }
  1. Spawn this item and see that the prefix is actually added:
    i
  2. Unlock all recepies through debug menu.
  3. [FIXED use item/tname instead of its raw name (nname) in recipe menu #72202]
    Open crafting menu. Note that the item in the left column (and in the right column when viewing nested recipes) is displayed without its prefix. Same for items in the middle column - tools and components - if you add a flag to the microwave:
    y
  4. Teleport to the refugee center and offer food to the beggar. In the dialog it is also displayed without a prefix.
    q

Expected behavior

I expect that the item in the left and middle column will be displayed with prefixes/suffixes. Like this:
y1

Screenshots

No response

Versions and configuration

  • OS: Linux
    • OS Version: Distributor ID: Debian; Description: Debian GNU/Linux 12 (bookworm); Release: 12; Codename: bookworm;
  • Game Version: 9d6677c [64-bit]
  • Graphics Version: Tiles
  • Game Language: English [en]
  • Mods loaded: [
    Dark Days Ahead [dda],
    Disable NPC Needs [no_npc_food],
    Portal Storms Ignore NPCs [personal_portal_storms],
    Slowdown Fungal Growth [no_fungal_growth]
    ]

Additional context

Fixed crafting menu

a
b

Building menu is ok
e

@Uwuewsky Uwuewsky added the (S1 - Need confirmation) Report waiting on confirmation of reproducibility label Mar 6, 2024
Copy link
Contributor

github-actions bot commented Apr 6, 2024

This issue has been automatically marked as stale because it has not had recent activity. It will be closed if no further activity occurs. Thank you for your contributions. Please do not bump or comment on this issue unless you are actively working on it. Stale issues, and stale issues that are closed are still considered.

@github-actions github-actions bot added the stale Closed for lack of activity, but still valid. label Apr 6, 2024
@Uwuewsky
Copy link
Contributor Author

Prefixes are not displayed in the e menu lines:
"Can be stored in"
desc
"Repair using"
desc1

In other blocks, like "Disassembly ... might yield" and "You could use it to craft", it is displayed correctly.

@github-actions github-actions bot removed the stale Closed for lack of activity, but still valid. label Apr 13, 2024
Copy link
Contributor

This issue has been automatically marked as stale because it has not had recent activity. It will be closed if no further activity occurs. Thank you for your contributions. Please do not bump or comment on this issue unless you are actively working on it. Stale issues, and stale issues that are closed are still considered.

@github-actions github-actions bot added the stale Closed for lack of activity, but still valid. label May 13, 2024
@Uwuewsky
Copy link
Contributor Author

I tried to do the same for ammunition. The text from the flag is not displayed in many places.
This is how the ammo name should be displayed (with , reloaded [DEGUG] (yes, degug)):

e

And here's where it doesn't show up:
c
Item suffix does not appear in container (magazine/gun):
d
firing menu:
f
Variants and Ammunition:
variants

@github-actions github-actions bot removed the stale Closed for lack of activity, but still valid. label May 20, 2024
Copy link
Contributor

This issue has been automatically marked as stale because it has not had recent activity. It will be closed if no further activity occurs. Thank you for your contributions. Please do not bump or comment on this issue unless you are actively working on it. Stale issues, and stale issues that are closed are still considered.

@github-actions github-actions bot added the stale Closed for lack of activity, but still valid. label Jun 19, 2024
@github-actions github-actions bot closed this as not planned Won't fix, can't repro, duplicate, stale Jul 19, 2024
@Brambor Brambor added (S2 - Confirmed) Bug that's been confirmed to exist and removed (S1 - Need confirmation) Report waiting on confirmation of reproducibility labels Jan 2, 2025
@Brambor
Copy link
Contributor

Brambor commented Jan 2, 2025

Yup, same issue. Let's finally confirm it so that it doesn't close again.

@Brambor Brambor reopened this Jan 2, 2025
@Brambor Brambor added Info / User Interface Game - player communication, menus, etc. Items: Variants Variants of items and removed stale Closed for lack of activity, but still valid. labels Jan 2, 2025
@Brambor
Copy link
Contributor

Brambor commented Jan 4, 2025

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
Info / User Interface Game - player communication, menus, etc. Items: Variants Variants of items (S2 - Confirmed) Bug that's been confirmed to exist
Projects
None yet
Development

No branches or pull requests

2 participants