Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Fix issue with bashing satalight dish and negative noise #78482

Merged
merged 1 commit into from
Dec 11, 2024
Merged
Changes from all commits
Commits
File filter

Filter by extension

Filter by extension

Conversations
Failed to load comments.
Loading
Jump to
Jump to file
Failed to load files.
Loading
Diff view
Diff view
Fix issue with bashing satalight dish and negative noise
WhaleYogurt authored Dec 11, 2024

Verified

This commit was created on GitHub.com and signed with GitHub’s verified signature. The key has expired.
commit 7265fb2cf559361c240e4856888dcfb35384c175
4 changes: 4 additions & 0 deletions data/json/furniture_and_terrain/furniture-roof.json
Original file line number Diff line number Diff line change
@@ -45,6 +45,10 @@
"required_str": 10,
"flags": [ "TRANSPARENT", "NOITEM" ],
"bash": {
"str_min": 6,
"str_max": 10,
"sound": "whack!",
"sound_fail": "womp!",
"items": [
{ "item": "scrap", "count": [ 4, 6 ] },
{ "item": "plastic_chunk", "count": [ 4, 12 ] },

Unchanged files with check annotations Beta

hostile.regen_ai_cache();
float danger_around = hostile.danger_assessment();
CHECK( danger_around > 1.0f );
CHECK( !hostile.get_wielded_item().get_item()->is_gun() );

Check failure on line 645 in tests/npc_test.cpp

GitHub Actions / GCC 12, Ubuntu cross-compile to MinGW-Win64, Tiles, Sound

false
hostile.wield_better_weapon();
CHECK( hostile.get_wielded_item().get_item()->is_gun() );
{
CHECK( is_char_allowed( '\0' ) == false );
CHECK( is_char_allowed( '\b' ) == false );
CHECK( is_char_allowed( '\t' ) == false );

Check failure on line 8 in tests/char_validity_check_test.cpp

GitHub Actions / GCC 12, Ubuntu cross-compile to MinGW-Win64, Tiles, Sound

true == false
CHECK( is_char_allowed( '\n' ) == false );
CHECK( is_char_allowed( '\r' ) == false );
CHECK( is_char_allowed( '\\' ) == false );