Fix issue with bashing satalight dish and negative noise #78482
Merged
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Pull Request: Fix Negative Sound When Smashing Satellite Dish
Summary
Bugfixes "Fix negative sound when smashing satellite dish"
Purpose of Change
This change resolves issue #77823, where smashing a satellite dish produced an error for a negative sound volume. The expected behavior is for a positive sound value to be generated when the dish is smashed, providing appropriate feedback to the player.
Describe the Solution
The fix involves adding
bash
properties to the satellite dish item, including:str_min
: 6str_max
: 10sound
: "whack!" for successful bashingsound_fail
: "womp!" for failed bashingscrap
(4–6 units) andplastic_chunk
(4–12 units).These changes resolves the negative sound bug.
Testing
The following steps were taken to test the fix:
"whack!"
or"womp!"
depending on success or failure.scrap
andplastic_chunk
) drop as intended.str_min
andstr_max
) are respected during bashing.Additional Context
This change improves gameplay interactions with the satellite dish and resolves the error encountered when smashing it. Below is an example of the new
bash
properties in JSON format:Related Issues
Fixes #77823.