Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Aftershock: Nerf spawn % of broken cyborg in basement_bionic #77897

Conversation

themaster567
Copy link
Contributor

@themaster567 themaster567 commented Nov 16, 2024

Summary

Balance "Aftershock: Reduce spawn chance of broken cyborgs in bionic basements"

Purpose of change

I feel like bionic_basement shouldn't have a 100% chance of spawning a broken cyborg. You know, because then you always know there's going to be a broken cyborg in it, meaning you can prepare for it in a way that I don't think was intended.

"It's a basement though, so how would yo-"

You hear "PLEASE GOD KILL ME AAAAAAAAAAAAAAAAAA" from 8 tiles away and below!

You know it's a bionic basement possibly before you even enter the house.

Describe the solution

Reduce the spawn chance of the broken cyborg in bionic basements from 100% to 25%.

Describe alternatives you've considered

Reducing it lower, keeping it higher, not changing it at all.

Testing

N/A: It's a single integer change.

Additional context

25% just feels right in my head, as I feel like there's a good chance that the cyborg resident holed up in a basement with no food would have wandered out into the world by the time the player arrives. However, I am completely down for discussing raising or lowering the number further if you think I'm off.

Side note, but the No Hope mod uses this basement as well and contains the same issue. I submitted a separate PR #77898 to perform the same nerf to it. This way, both sets of maintainers can make independent decisions on if they want to accept this change.

@github-actions github-actions bot added [JSON] Changes (can be) made in JSON Mods Issues related to mods or modding Bionics CBM (Compact Bionic Modules) Map / Mapgen Overmap, Mapgen, Map extras, Map display Mods: Aftershock Anything to do with the Aftershock mod labels Nov 16, 2024
@github-actions github-actions bot added Game: Balance Balancing of (existing) in-game features. json-styled JSON lint passed, label assigned by github actions astyled astyled PR, label is assigned by github actions labels Nov 16, 2024
@github-actions github-actions bot added the BasicBuildPassed This PR builds correctly, label assigned by github actions label Nov 18, 2024
@Night-Pryanik Night-Pryanik merged commit 22d45f7 into CleverRaven:master Nov 18, 2024
23 of 29 checks passed
@themaster567 themaster567 deleted the as-broken-cyborgs-too-predictable branch November 18, 2024 12:06
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
astyled astyled PR, label is assigned by github actions BasicBuildPassed This PR builds correctly, label assigned by github actions Bionics CBM (Compact Bionic Modules) Game: Balance Balancing of (existing) in-game features. [JSON] Changes (can be) made in JSON json-styled JSON lint passed, label assigned by github actions Map / Mapgen Overmap, Mapgen, Map extras, Map display Mods: Aftershock Anything to do with the Aftershock mod Mods Issues related to mods or modding
Projects
None yet
Development

Successfully merging this pull request may close these issues.

2 participants