Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Parametrize all walls: Part 1 #77459

Merged
merged 8 commits into from
Nov 2, 2024
Merged

Conversation

Milopetilo
Copy link
Contributor

Summary

None

Purpose of change

Use the palettes added in #77273 in order to have a bit more variation in walls.

Describe the solution

Look for every mapgen file that uses walls and apply the palette there. I've tried to avoid to change areas where the walls were chosen for specific reasons.

Describe alternatives you've considered

Not do this and stay sane.

Testing

Game loads, checked out some of the changed mapgen and it looks different.

Additional context

Might have merge conflict with #77287 but am unsure if it will.
This part has buildings with names starting from a-g, I'll try split up the next PRs in the same way.

@github-actions github-actions bot added [JSON] Changes (can be) made in JSON Map / Mapgen Overmap, Mapgen, Map extras, Map display json-styled JSON lint passed, label assigned by github actions astyled astyled PR, label is assigned by github actions BasicBuildPassed This PR builds correctly, label assigned by github actions labels Oct 30, 2024
@Maleclypse
Copy link
Member

Do you mind making a PR that shows what parameters someone should use when adding new mapgen to the mapgen.md docs? Basically the goal is to avoid people having to come back and reparametrize new maps.

@github-actions github-actions bot removed the BasicBuildPassed This PR builds correctly, label assigned by github actions label Oct 31, 2024
@github-actions github-actions bot added the BasicBuildPassed This PR builds correctly, label assigned by github actions label Oct 31, 2024
@Maleclypse Maleclypse merged commit f2b87b8 into CleverRaven:master Nov 2, 2024
17 of 24 checks passed
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
astyled astyled PR, label is assigned by github actions BasicBuildPassed This PR builds correctly, label assigned by github actions [JSON] Changes (can be) made in JSON json-styled JSON lint passed, label assigned by github actions Map / Mapgen Overmap, Mapgen, Map extras, Map display
Projects
None yet
Development

Successfully merging this pull request may close these issues.

2 participants