Remove furniture/terrain legacy alias code and JSON #77523
Merged
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Summary
Infrastructure "remove furniture/terrain legacy alias code and JSON"
Purpose of change
This is roughly half of #73211, which indeed turned out to have too many issues to rebase completely. From that PR, the rationale: "Removes remaining redundant aliases and alias code".
This work was done by @Procyonae, I just isolated the changes and cleaned them up.
Describe the solution
I mostly solved merge conflicts, and I made sure that any remaining "alias" fields don't exist in the "json" or "mods" directories.
I'm aware of #77459 and made sure to rebase over it; there weren't any serious conflicts.
Describe alternatives you've considered
Doing this from scratch would require a lot more work, I think.
Testing
Additional context
Additional thanks to @Procyonae for doing the original work