Add TRANSLUCENT terrain flag which blocks vision but not light #76290
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
TRANSLUCENT can be used in combination with TRANSPARENT to create tiles which admit light but block vision, such as fosted glass, stained glass, or to simulate tall walls with small windows placed high up. This is a binary implementation, which does not leverage the transluceny and lighting falloff system used by (e.g.) fields. This approach was taken in order to simplify the developer experience: you can simply add a flag to the terrain without having to know precisely what transluceny value would be requried to block all vision through the tile. Future work could leverage the transluceny and lighting falloff system to enable (e.g.) semi-translucent windows that let you see just a few tiles out.
github-actions
bot
added
[JSON]
github-actions
bot
added
<Documentation>
|
Excellent idea! I've wanted this functionality for a while |
Vgoloshivskiy
pushed a commit
to Vgoloshivskiy/Cataclysm-DDA
that referenced
this pull request
Sep 8, 2024
GuardianDll
commented
Sep 9, 2024
CLIDragon
suggested changes
Sep 9, 2024
github-actions
bot
added
the
BasicBuildPassed
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Summary
None
Purpose of change
Reopen #61872
Describe the solution
Fix conflicts mostly
Testing
with flashlight inside at night
Additional context
Previous PR was drafted because it was pointed terrain should not require TRANSPARENT flag, i fixed it