Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Let light through but not sight #56633

Closed
Fris0uman opened this issue Apr 6, 2022 · 4 comments
Closed

Let light through but not sight #56633

Fris0uman opened this issue Apr 6, 2022 · 4 comments
Labels
<Enhancement / Feature> New features, or enhancements on existing Fields / Furniture / Terrain / Traps Objects that are part of the map or its features. (P5 - Long-term) Long-term WIP, may stay on the list for a while. <Suggestion / Discussion> Talk it out before implementing

Comments

@Fris0uman
Copy link
Contributor

Is your feature request related to a problem? Please describe.

Standing in front of stained glass windows in broad day light and yet I'm still in darkness.

image

It would be nice if the engine could support letting light through a tile without making the tile see through

Solution you would like.

Being able to have some terrain/furniture obstruct sight without bloking light completly. It could allow stained glass to let light through but alos stuff like having some light pass throguh boarded up windows or under doors.

Describe alternatives you have considered.

No response

Additional context

No response

@Maleclypse Maleclypse added <Suggestion / Discussion> Talk it out before implementing <Enhancement / Feature> New features, or enhancements on existing Fields / Furniture / Terrain / Traps Objects that are part of the map or its features. labels Apr 20, 2022
@Zireael07
Copy link
Contributor

Would also be useful for frosted glass windows, e.g. in changing rooms and bathrooms

@RAldrich
Copy link
Contributor

This is reasonably straightforward on the player vision side of things, the lighting code is already split between light transparency and vision transparency, and supports translucency / light attenuation. I have working version that lets light through but prevents player vision.

I still need to figure out the monster vision code half of it, as they seem to be able to be able to asymmetrically see the player for 6 tiles or so.

That monster behavior might actually be desirable though, insofar as it lets them see motion behind the window? I'll probably try to figure out why it's happening either way before I post a PR for this.

@github-actions
Copy link
Contributor

github-actions bot commented Jan 4, 2023

This issue has been automatically marked as stale because it has not had recent activity. It will be closed if no further activity occurs. Thank you for your contributions. Please do not bump or comment on this issue unless you are actively working on it. Stale issues, and stale issues that are closed are still considered.

@github-actions github-actions bot added the stale Closed for lack of activity, but still valid. label Jan 4, 2023
@github-actions github-actions bot closed this as not planned Won't fix, can't repro, duplicate, stale Feb 3, 2023
@Fris0uman Fris0uman added (P5 - Long-term) Long-term WIP, may stay on the list for a while. and removed stale Closed for lack of activity, but still valid. labels Feb 7, 2023
@Fris0uman Fris0uman reopened this Feb 7, 2023
@Brambor
Copy link
Contributor

Brambor commented Dec 22, 2024

@Brambor Brambor closed this as completed Dec 22, 2024
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
<Enhancement / Feature> New features, or enhancements on existing Fields / Furniture / Terrain / Traps Objects that are part of the map or its features. (P5 - Long-term) Long-term WIP, may stay on the list for a while. <Suggestion / Discussion> Talk it out before implementing
Projects
None yet
Development

Successfully merging a pull request may close this issue.

5 participants