Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Gun Cleaning update #76229

Open
wants to merge 4 commits into
base: master
Choose a base branch
from
Open
Show file tree
Hide file tree
Changes from all commits
Commits
File filter

Filter by extension

Filter by extension

Conversations
Failed to load comments.
Loading
Jump to
Jump to file
Failed to load files.
Loading
Diff view
Diff view
8 changes: 8 additions & 0 deletions data/json/faults/faults_guns.json
Copy link
Contributor

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

This looks like a lot of detail for very little gain. It would be cool if we had true realism like different size bolts and consequently different sized wrenches (10mm, 9mm, etc...), but it looks like we're only at the "screwdriver" and "screwdriver set" level of detail. Typically when I need to clean a gun and don't have a proper head attachment for the barrel size, I just compensate by adding more cloth patches (or fewer if the barrel is tighter). Likewise we can use a wire for smaller barrels or bend the wire in two for more rigidity/thickness.

image

I would delete this change since it needlessly complicates things.

Original file line number Diff line number Diff line change
@@ -1,4 +1,12 @@
[
{
"id": "fault_gun_flintlock",
"type": "fault",
"name": { "str": "Flintlock fouling" },
"description": "Firing blackpowder loads from a flintlock fouls it, which reduces reliability and, if left uncleaned, leads to rust. It fouls the gun much faster than the use of modern smokeless powder cartridges. Fouling is only a significant impact on reliability at high levels, but black powder fouling accumulates quickly.",
"item_prefix": "rusting",
"flags": [ "BLACKPOWDER_FOULING_DAMAGE", "NO_DIRTYING" ]
},
Comment on lines +2 to +9
Copy link
Contributor

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Suggested change
{
"id": "fault_gun_flintlock",
"type": "fault",
"name": { "str": "Flintlock fouling" },
"description": "Firing blackpowder loads from a flintlock fouls it, which reduces reliability and, if left uncleaned, leads to rust. It fouls the gun much faster than the use of modern smokeless powder cartridges. Fouling is only a significant impact on reliability at high levels, but black powder fouling accumulates quickly.",
"item_prefix": "rusting",
"flags": [ "BLACKPOWDER_FOULING_DAMAGE", "NO_DIRTYING" ]
},

{
"id": "fault_gun_blackpowder",
"type": "fault",
Expand Down
12 changes: 12 additions & 0 deletions data/json/items/classes/gun.json
Original file line number Diff line number Diff line change
Expand Up @@ -18,6 +18,18 @@
],
"ranged_damage": { "damage_type": "bullet", "amount": 0 }
},
{
"abstract": "flintlock_base",
"type": "GUN",
"reload_noise_volume": 10,
"//": "this is the default handling for anything with a flintlock",
"handling": 20,
"name": { "str": "flintlock gun" },
"symbol": "(",
"color": "light_gray",
"faults": [ "fault_gun_flintlock", "fault_gun_dirt", "fault_gun_chamber_spent" ],
"ranged_damage": { "damage_type": "bullet", "amount": 0 }
},
Comment on lines +21 to +32
Copy link
Contributor

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Suggested change
{
"abstract": "flintlock_base",
"type": "GUN",
"reload_noise_volume": 10,
"//": "this is the default handling for anything with a flintlock",
"handling": 20,
"name": { "str": "flintlock gun" },
"symbol": "(",
"color": "light_gray",
"faults": [ "fault_gun_flintlock", "fault_gun_dirt", "fault_gun_chamber_spent" ],
"ranged_damage": { "damage_type": "bullet", "amount": 0 }
},

{
"abstract": "underbarrel_base",
"type": "GUN",
Expand Down
13 changes: 13 additions & 0 deletions data/json/items/generic.json
Original file line number Diff line number Diff line change
Expand Up @@ -2200,6 +2200,19 @@
"symbol": ";",
"color": "light_gray"
},
{
"id": "pipe_dowel",
"type": "GENERIC",
"name": { "str": "pipe dowel" },
"description": "A tool designed to fit inside of pipes, bottles, and similar objects. This one is thick enough to be used for cleaning flintlock barrels from dirt and fouling.",
"weight": "100 g",
"volume": "250 ml",
"price": "5 USD",
"price_postapoc": "50 cent",
"material": [ "steel" ],
"symbol": ";",
"color": "light_gray"
},
Comment on lines +2203 to +2215
Copy link
Contributor

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Suggested change
{
"id": "pipe_dowel",
"type": "GENERIC",
"name": { "str": "pipe dowel" },
"description": "A tool designed to fit inside of pipes, bottles, and similar objects. This one is thick enough to be used for cleaning flintlock barrels from dirt and fouling.",
"weight": "100 g",
"volume": "250 ml",
"price": "5 USD",
"price_postapoc": "50 cent",
"material": [ "steel" ],
"symbol": ";",
"color": "light_gray"
},

{
"type": "GENERIC",
"id": "clock",
Expand Down
2 changes: 2 additions & 0 deletions data/json/items/gun/flintlock.json
Original file line number Diff line number Diff line change
Expand Up @@ -41,8 +41,9 @@
{
"id": "pistol_flintlock",
"looks_like": "glock_17",
"copy-from": "flintlock_base",
Copy link
Contributor

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Suggested change
"copy-from": "flintlock_base",

"type": "GUN",
"reload_noise_volume": 10,

Check failure on line 46 in data/json/items/gun/flintlock.json

View workflow job for this annotation

GitHub Actions / Basic Build and Test (Clang 10, Ubuntu, Curses)

(~[slow] ~[.],starting_items)=> cannot assign explicit value the same as default or inherited value "copy-from": "flintlock_base", "type": "GUN", "reload_noise_volume": 10, ▲▲▲ "name": { "str": "flintlock pistol" }, "description": "A beautifully decorated flintlock pistol. If using this doesn't make you feel a pirate, nothing will.",

Check failure on line 46 in data/json/items/gun/flintlock.json

View workflow job for this annotation

GitHub Actions / Basic Build and Test (Clang 10, Ubuntu, Curses)

([slow] ~starting_items)=> cannot assign explicit value the same as default or inherited value "copy-from": "flintlock_base", "type": "GUN", "reload_noise_volume": 10, ▲▲▲ "name": { "str": "flintlock pistol" }, "description": "A beautifully decorated flintlock pistol. If using this doesn't make you feel a pirate, nothing will.",
"name": { "str": "flintlock pistol" },
"description": "A beautifully decorated flintlock pistol. If using this doesn't make you feel a pirate, nothing will.",
"weight": "1 kg",
Expand Down Expand Up @@ -71,8 +72,9 @@
{
"id": "rifle_flintlock",
"looks_like": "modular_ar15",
"copy-from": "flintlock_base",
Copy link
Contributor

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Suggested change
"copy-from": "flintlock_base",

"type": "GUN",
"reload_noise_volume": 10,

Check failure on line 77 in data/json/items/gun/flintlock.json

View workflow job for this annotation

GitHub Actions / Basic Build and Test (Clang 10, Ubuntu, Curses)

(~[slow] ~[.],starting_items)=> cannot assign explicit value the same as default or inherited value "copy-from": "flintlock_base", "type": "GUN", "reload_noise_volume": 10, ▲▲▲ "name": { "str": "flintlock musket" }, "description": "For once, something *good* came back from the dead. This ancient design lacks the fire-rate of modern weapons, but packs as much punch as the best of 'em and rewards the skilled shooter with easily-crafted ammunition.",

Check failure on line 77 in data/json/items/gun/flintlock.json

View workflow job for this annotation

GitHub Actions / Basic Build and Test (Clang 10, Ubuntu, Curses)

([slow] ~starting_items)=> cannot assign explicit value the same as default or inherited value "copy-from": "flintlock_base", "type": "GUN", "reload_noise_volume": 10, ▲▲▲ "name": { "str": "flintlock musket" }, "description": "For once, something *good* came back from the dead. This ancient design lacks the fire-rate of modern weapons, but packs as much punch as the best of 'em and rewards the skilled shooter with easily-crafted ammunition.",
"name": { "str": "flintlock musket" },
"description": "For once, something *good* came back from the dead. This ancient design lacks the fire-rate of modern weapons, but packs as much punch as the best of 'em and rewards the skilled shooter with easily-crafted ammunition.",
"weight": "4900 g",
Expand Down
30 changes: 24 additions & 6 deletions data/json/requirements/toolsets.json
Original file line number Diff line number Diff line change
Expand Up @@ -28,7 +28,10 @@
"type": "requirement",
"//": "Gun cleaning",
"qualities": [ { "id": "SCREW", "level": 1 } ],
"tools": [ [ [ "pipe_cleaner", -1 ], [ "small_repairkit", -1 ], [ "large_repairkit", -1 ] ] ],
"tools": [
[ [ "pipe_cleaner", -1 ], [ "small_repairkit", -1 ], [ "large_repairkit", -1 ] ],
Copy link
Contributor

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Suggested change
[ [ "pipe_cleaner", -1 ], [ "small_repairkit", -1 ], [ "large_repairkit", -1 ] ],
[ [ "lc_wire", -1 ], [ "mc_wire", -1 ], [ "hc_wire", -1 ], [ "qt_wire", -1 ], [ "ch_wire", -1 ], [ "cable", -1 ], [ "string_36", -1 ], [ "small_repairkit", -1 ], [ "large_repairkit", -1 ] ],

[ [ "cotton_patchwork", 1 ], [ "fur", 1 ], [ "faux_fur", 1 ], [ "felt_patch", 1 ], [ "cotton_ball", 2 ] ]
],
"components": [
[
[ "gasoline", 125 ],
Expand All @@ -44,14 +47,27 @@
[ "vinegar", 8 ],
[ "ammonia_hydroxide", 1 ],
[ "bleach", 1 ]
],
]
]
},
{
"id": "gun_cleaning_flintlock",
"type": "requirement",
"//": "Flintlocks require a thicker tool to manage the wider barrel and also soapy water to clean the blackpowder.",
"qualities": [ { "id": "SCREW", "level": 1 } ],
"tools": [
[ [ "pipe_dowel", -1 ], [ "small_repairkit", -1 ], [ "large_repairkit", -1 ] ],
[ [ "water_boiling_heat", 2, "LIST" ] ]
],
"components": [
[ [ "soapy_water", 3 ] ],
[ [ "cotton_patchwork", 1 ], [ "fur", 1 ], [ "faux_fur", 1 ], [ "felt_patch", 1 ], [ "cotton_ball", 2 ] ]
]
},
Comment on lines +53 to 66
Copy link
Contributor

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Suggested change
{
"id": "gun_cleaning_flintlock",
"type": "requirement",
"//": "Flintlocks require a thicker tool to manage the wider barrel and also soapy water to clean the blackpowder.",
"qualities": [ { "id": "SCREW", "level": 1 } ],
"tools": [
[ [ "pipe_dowel", -1 ], [ "small_repairkit", -1 ], [ "large_repairkit", -1 ] ],
[ [ "water_boiling_heat", 2, "LIST" ] ]
],
"components": [
[ [ "soapy_water", 3 ] ],
[ [ "cotton_patchwork", 1 ], [ "fur", 1 ], [ "faux_fur", 1 ], [ "felt_patch", 1 ], [ "cotton_ball", 2 ] ]
]
},

{
"id": "gun_cleaning_bp",
"type": "requirement",
"//": "BP requires hot soapy water",
"//": "BP requires hot soapy water. The cloth patch is for cleaning gunk off the rod. Not reusable because of black powder residue.",
"qualities": [ { "id": "SCREW", "level": 1 } ],
"tools": [
[ [ "pipe_cleaner", -1 ], [ "small_repairkit", -1 ], [ "large_repairkit", -1 ] ],
Expand All @@ -65,9 +81,11 @@
{
"id": "gun_cleaning_quick",
"type": "requirement",
"//": "Requires a rod/wire and cloth patch or similar item.",
"tools": [ [ [ "pipe_cleaner", -1 ], [ "small_repairkit", -1 ], [ "large_repairkit", -1 ] ] ],
"components": [ [ [ "cotton_patchwork", 1 ], [ "fur", 1 ], [ "faux_fur", 1 ], [ "felt_patch", 1 ], [ "cotton_ball", 2 ] ] ]
"//": "Requires a rod/wire and cloth patch or similar item. The cloth patch et al is for cleaning gunk off the rod/wire/pipe cleaner.",
"tools": [
[ [ "pipe_cleaner", -1 ], [ "small_repairkit", -1 ], [ "large_repairkit", -1 ] ],
Copy link
Contributor

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Suggested change
[ [ "pipe_cleaner", -1 ], [ "small_repairkit", -1 ], [ "large_repairkit", -1 ] ],
[ [ "lc_wire", -1 ], [ "mc_wire", -1 ], [ "hc_wire", -1 ], [ "qt_wire", -1 ], [ "ch_wire", -1 ], [ "cable", -1 ], [ "string_36", -1 ], [ "small_repairkit", -1 ], [ "large_repairkit", -1 ] ],

[ [ "cotton_patchwork", 1 ], [ "fur", 1 ], [ "faux_fur", 1 ], [ "felt_patch", 1 ] ]
]
},
{
"id": "gun_lubrication",
Expand Down
23 changes: 23 additions & 0 deletions data/mods/innawood/recipes/recipe_others.json
Original file line number Diff line number Diff line change
Expand Up @@ -53,6 +53,29 @@
[ [ "plastic_chunk", 1 ] ]
]
},
{
"type": "recipe",
"activity_level": "LIGHT_EXERCISE",
"result": "pipe_dowel",
"category": "CC_OTHER",
"subcategory": "CSC_OTHER_TOOLS",
"skill_used": "mechanics",
"difficulty": 1,
"time": "2 m",
"reversible": true,
"autolearn": true,
"components": [
[
[ "wire", 4 ],
[ "lc_wire", 4 ],
[ "mc_wire", 4 ],
[ "hc_wire", 4 ],
[ "qt_wire", 4 ],
[ "ch_wire", 4 ],
[ "cable", 4 ]
]
]
},
Comment on lines +56 to +78
Copy link
Contributor

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Suggested change
{
"type": "recipe",
"activity_level": "LIGHT_EXERCISE",
"result": "pipe_dowel",
"category": "CC_OTHER",
"subcategory": "CSC_OTHER_TOOLS",
"skill_used": "mechanics",
"difficulty": 1,
"time": "2 m",
"reversible": true,
"autolearn": true,
"components": [
[
[ "wire", 4 ],
[ "lc_wire", 4 ],
[ "mc_wire", 4 ],
[ "hc_wire", 4 ],
[ "qt_wire", 4 ],
[ "ch_wire", 4 ],
[ "cable", 4 ]
]
]
},

{
"type": "recipe",
"activity_level": "LIGHT_EXERCISE",
Expand Down
Loading