-
Notifications
You must be signed in to change notification settings - Fork 4.2k
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
Gun Cleaning update #76229
base: master
Are you sure you want to change the base?
Gun Cleaning update #76229
Conversation
No our pipe cleaners represented this. https://otistec.com/100-pack-pipe-cleaners/ |
I’m familiar with that and it’s represented in the quick cleaning action.
…On Thu, Sep 5, 2024 at 8:22 PM misterprimus ***@***.***> wrote:
Just so we're on the same page, this is pretty much what cleaning a gun in
survival conditions is mostly like:
gunclean.gif (view on web)
<https://github.com/user-attachments/assets/bfbd521c-5396-4aca-b741-332157f7752b>
—
Reply to this email directly, view it on GitHub
<#76229 (comment)>,
or unsubscribe
<https://github.com/notifications/unsubscribe-auth/AM6UAQB33OCNVNRCFQZGS5DZVD7UBAVCNFSM6AAAAABNXRXHHOVHI2DSMVQWIX3LMV43OSLTON2WKQ3PNVWWK3TUHMZDGMZSHE4TONRWG4>
.
You are receiving this because you authored the thread.Message ID:
***@***.***>
|
Understood. But then are pipe cleaners going to be totally unnecessary for cleaning a gun? Because in all my years of cleaning guns, I've never used a pipe cleaner like that or seen one in a retail cleaning kit. Most gun cleaning kits are basically this: And in my personal experience, the rod + a patch with solvent/oil is basically what's used 99% of the time. So I'm still a little confused as to what the pipe cleaner (anatomically correct as it may be in your adjusted recipe) is supposed to do as far as role fulfillment is concerned for barrel-cleaning. The barrel-cleaning phase is done with a rod, cloth, and solvent. Barrel brushing, in the few instances when it is done, is done with copper/brass brushes. Neither of these would be accomplished with the pipe cleaners you posted. |
I only use them on once a year or longer full disassemble and cleaning. I don't think they are an ideal tool for it as the main tool but I was being kind to the pc and suggesting it could be used assuming they lacked a real gun kit. I'm personally fine with removing it entirely but the other things are going to be much harder for the player to self craft. |
Lots of things can function as the rod. A long screwdriver for example. Chopstick (eating utensil) for smaller size barrels like that of a handgun. Or a straightened coat hanger (the "wire" as it was in the past). And that's if you're ramming. If you pull (which would accomplish a similar result), you can just tie a wire or a string to the cloth and pull. https://www.youtube.com/watch?v=pDHYkWD7jYs |
We don’t represent individual long screwdrivers so they’d have to be a screwdriver set, chopsticks are rare in game. I’m not debating you but you aren’t suggesting changes that I can accept as additions and substractions from the recipe. What I’m saying here is that if you have useful suggestions make them easy for me to work with. I’m trying to put my children to sleep so anything else outside of any suggested code changes from you is beyond the scope of what I’m doing in this PR. |
Then I'd say let a "wire" (incl. mild steel, etc...) or even a "rope" or "long string" be usable as the "tool" needed to clean a gun. And require the cleaning step to consume a cotton patch and some solvent/cleaning solution. Does that sound agreeable? |
That does. Do you mind adding it in this PR as code suggestions on the files tab? |
@@ -28,7 +28,10 @@ | |||
"type": "requirement", | |||
"//": "Gun cleaning", | |||
"qualities": [ { "id": "SCREW", "level": 1 } ], | |||
"tools": [ [ [ "pipe_cleaner", -1 ], [ "small_repairkit", -1 ], [ "large_repairkit", -1 ] ] ], | |||
"tools": [ | |||
[ [ "pipe_cleaner", -1 ], [ "small_repairkit", -1 ], [ "large_repairkit", -1 ] ], |
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
[ [ "pipe_cleaner", -1 ], [ "small_repairkit", -1 ], [ "large_repairkit", -1 ] ], | |
[ [ "lc_wire", -1 ], [ "mc_wire", -1 ], [ "hc_wire", -1 ], [ "qt_wire", -1 ], [ "ch_wire", -1 ], [ "cable", -1 ], [ "string_36", -1 ], [ "small_repairkit", -1 ], [ "large_repairkit", -1 ] ], |
"components": [ [ [ "cotton_patchwork", 1 ], [ "fur", 1 ], [ "faux_fur", 1 ], [ "felt_patch", 1 ], [ "cotton_ball", 2 ] ] ] | ||
"//": "Requires a rod/wire and cloth patch or similar item. The cloth patch et al is for cleaning gunk off the rod/wire/pipe cleaner.", | ||
"tools": [ | ||
[ [ "pipe_cleaner", -1 ], [ "small_repairkit", -1 ], [ "large_repairkit", -1 ] ], |
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
[ [ "pipe_cleaner", -1 ], [ "small_repairkit", -1 ], [ "large_repairkit", -1 ] ], | |
[ [ "lc_wire", -1 ], [ "mc_wire", -1 ], [ "hc_wire", -1 ], [ "qt_wire", -1 ], [ "ch_wire", -1 ], [ "cable", -1 ], [ "string_36", -1 ], [ "small_repairkit", -1 ], [ "large_repairkit", -1 ] ], |
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
This looks like a lot of detail for very little gain. It would be cool if we had true realism like different size bolts and consequently different sized wrenches (10mm, 9mm, etc...), but it looks like we're only at the "screwdriver" and "screwdriver set" level of detail. Typically when I need to clean a gun and don't have a proper head attachment for the barrel size, I just compensate by adding more cloth patches (or fewer if the barrel is tighter). Likewise we can use a wire for smaller barrels or bend the wire in two for more rigidity/thickness.
I would delete this change since it needlessly complicates things.
@@ -41,6 +41,7 @@ | |||
{ | |||
"id": "pistol_flintlock", | |||
"looks_like": "glock_17", | |||
"copy-from": "flintlock_base", |
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
"copy-from": "flintlock_base", |
@@ -71,6 +72,7 @@ | |||
{ | |||
"id": "rifle_flintlock", | |||
"looks_like": "modular_ar15", | |||
"copy-from": "flintlock_base", |
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
"copy-from": "flintlock_base", |
{ | ||
"id": "fault_gun_flintlock", | ||
"type": "fault", | ||
"name": { "str": "Flintlock fouling" }, | ||
"description": "Firing blackpowder loads from a flintlock fouls it, which reduces reliability and, if left uncleaned, leads to rust. It fouls the gun much faster than the use of modern smokeless powder cartridges. Fouling is only a significant impact on reliability at high levels, but black powder fouling accumulates quickly.", | ||
"item_prefix": "rusting", | ||
"flags": [ "BLACKPOWDER_FOULING_DAMAGE", "NO_DIRTYING" ] | ||
}, |
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
{ | |
"id": "fault_gun_flintlock", | |
"type": "fault", | |
"name": { "str": "Flintlock fouling" }, | |
"description": "Firing blackpowder loads from a flintlock fouls it, which reduces reliability and, if left uncleaned, leads to rust. It fouls the gun much faster than the use of modern smokeless powder cartridges. Fouling is only a significant impact on reliability at high levels, but black powder fouling accumulates quickly.", | |
"item_prefix": "rusting", | |
"flags": [ "BLACKPOWDER_FOULING_DAMAGE", "NO_DIRTYING" ] | |
}, |
{ | ||
"abstract": "flintlock_base", | ||
"type": "GUN", | ||
"reload_noise_volume": 10, | ||
"//": "this is the default handling for anything with a flintlock", | ||
"handling": 20, | ||
"name": { "str": "flintlock gun" }, | ||
"symbol": "(", | ||
"color": "light_gray", | ||
"faults": [ "fault_gun_flintlock", "fault_gun_dirt", "fault_gun_chamber_spent" ], | ||
"ranged_damage": { "damage_type": "bullet", "amount": 0 } | ||
}, |
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
{ | |
"abstract": "flintlock_base", | |
"type": "GUN", | |
"reload_noise_volume": 10, | |
"//": "this is the default handling for anything with a flintlock", | |
"handling": 20, | |
"name": { "str": "flintlock gun" }, | |
"symbol": "(", | |
"color": "light_gray", | |
"faults": [ "fault_gun_flintlock", "fault_gun_dirt", "fault_gun_chamber_spent" ], | |
"ranged_damage": { "damage_type": "bullet", "amount": 0 } | |
}, |
{ | ||
"id": "pipe_dowel", | ||
"type": "GENERIC", | ||
"name": { "str": "pipe dowel" }, | ||
"description": "A tool designed to fit inside of pipes, bottles, and similar objects. This one is thick enough to be used for cleaning flintlock barrels from dirt and fouling.", | ||
"weight": "100 g", | ||
"volume": "250 ml", | ||
"price": "5 USD", | ||
"price_postapoc": "50 cent", | ||
"material": [ "steel" ], | ||
"symbol": ";", | ||
"color": "light_gray" | ||
}, |
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
{ | |
"id": "pipe_dowel", | |
"type": "GENERIC", | |
"name": { "str": "pipe dowel" }, | |
"description": "A tool designed to fit inside of pipes, bottles, and similar objects. This one is thick enough to be used for cleaning flintlock barrels from dirt and fouling.", | |
"weight": "100 g", | |
"volume": "250 ml", | |
"price": "5 USD", | |
"price_postapoc": "50 cent", | |
"material": [ "steel" ], | |
"symbol": ";", | |
"color": "light_gray" | |
}, |
{ | ||
"type": "recipe", | ||
"activity_level": "LIGHT_EXERCISE", | ||
"result": "pipe_dowel", | ||
"category": "CC_OTHER", | ||
"subcategory": "CSC_OTHER_TOOLS", | ||
"skill_used": "mechanics", | ||
"difficulty": 1, | ||
"time": "2 m", | ||
"reversible": true, | ||
"autolearn": true, | ||
"components": [ | ||
[ | ||
[ "wire", 4 ], | ||
[ "lc_wire", 4 ], | ||
[ "mc_wire", 4 ], | ||
[ "hc_wire", 4 ], | ||
[ "qt_wire", 4 ], | ||
[ "ch_wire", 4 ], | ||
[ "cable", 4 ] | ||
] | ||
] | ||
}, |
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
{ | |
"type": "recipe", | |
"activity_level": "LIGHT_EXERCISE", | |
"result": "pipe_dowel", | |
"category": "CC_OTHER", | |
"subcategory": "CSC_OTHER_TOOLS", | |
"skill_used": "mechanics", | |
"difficulty": 1, | |
"time": "2 m", | |
"reversible": true, | |
"autolearn": true, | |
"components": [ | |
[ | |
[ "wire", 4 ], | |
[ "lc_wire", 4 ], | |
[ "mc_wire", 4 ], | |
[ "hc_wire", 4 ], | |
[ "qt_wire", 4 ], | |
[ "ch_wire", 4 ], | |
[ "cable", 4 ] | |
] | |
] | |
}, |
{ | ||
"id": "gun_cleaning_flintlock", | ||
"type": "requirement", | ||
"//": "Flintlocks require a thicker tool to manage the wider barrel and also soapy water to clean the blackpowder.", | ||
"qualities": [ { "id": "SCREW", "level": 1 } ], | ||
"tools": [ | ||
[ [ "pipe_dowel", -1 ], [ "small_repairkit", -1 ], [ "large_repairkit", -1 ] ], | ||
[ [ "water_boiling_heat", 2, "LIST" ] ] | ||
], | ||
"components": [ | ||
[ [ "soapy_water", 3 ] ], | ||
[ [ "cotton_patchwork", 1 ], [ "fur", 1 ], [ "faux_fur", 1 ], [ "felt_patch", 1 ], [ "cotton_ball", 2 ] ] | ||
] | ||
}, |
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
{ | |
"id": "gun_cleaning_flintlock", | |
"type": "requirement", | |
"//": "Flintlocks require a thicker tool to manage the wider barrel and also soapy water to clean the blackpowder.", | |
"qualities": [ { "id": "SCREW", "level": 1 } ], | |
"tools": [ | |
[ [ "pipe_dowel", -1 ], [ "small_repairkit", -1 ], [ "large_repairkit", -1 ] ], | |
[ [ "water_boiling_heat", 2, "LIST" ] ] | |
], | |
"components": [ | |
[ [ "soapy_water", 3 ] ], | |
[ [ "cotton_patchwork", 1 ], [ "fur", 1 ], [ "faux_fur", 1 ], [ "felt_patch", 1 ], [ "cotton_ball", 2 ] ] | |
] | |
}, |
Something else I thought of is perhaps creating a "makeshift gun cleaning rod" out of a wire (any kind of wire) to simulate the process of bending a wire into a shape needed to be used for such a purpose (bending it in two for example). Kind of like a pipe is "shaped" into a makeshift crowbar. But it's your PR so up to you what sort of direction you want to go if you want to do what I recommended and just use a wire directly for the cleaning process. LMK and I can make that change probably. |
Considering plastic coating is irrelevant to its function, raw copper wire( |
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Auto-requesting reviews from non-collaborators: @Light-Wave
Summary
Bugfixes "Minor fixes in gun cleaning"
Purpose of change
I saw in #76187 that pipe cleaners create cotton out of thin air. I've fixed that in another PR. Then I've taken a look at the different types of gun cleaning and adjusted them as needed. In many cases the cleaning cloth is now reusable. I am curious if there is some way to make the cloth dirty.
Describe the solution
Adds pipe dowel and then adjusts and adds a different cleaning type. Will add the fault to mend in flintlocks.
Describe alternatives you've considered
Leaving this to someone else but other people are slow when I can fix it myself fast.
Testing
tbd
Additional context