Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

[Sky Island] Make bettter security containers obtainable #75882

Closed
wants to merge 3 commits into from
Closed

[Sky Island] Make bettter security containers obtainable #75882

Show file tree
Hide file tree
Changes from all commits
Commits
Show all changes
3 commits
Select commit Hold shift + click to select a range
bed3652
Add files via upload
Naadn Aug 22, 2024
e152d1b
Fix the unobtainable security boxs upgrade mission
Naadn Aug 22, 2024
96c2233
Fix the mission description and effect
Naadn Aug 22, 2024
File filter

Filter by extension

Filter by extension
Conversations
Failed to load comments.
Loading
Jump to
Jump to file
Failed to load files.
Loading
Diff view
Diff view
12 changes: 4 additions & 8 deletions data/mods/Sky_Island/dialog_statue.json
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -203,8 +203,7 @@
"and": [
{ "not": { "u_has_mission": "SKYISLAND_UPGRADE_security2" } },
{ "math": [ "securitylevel", "==", "1" ] },
{ "math": [ "islandrank", ">=", "2" ] },
{ "math": [ "debug_never_achievable", "==", "1" ] }
{ "math": [ "islandrank", ">=", "2" ] }
]
},
"effect": [ { "assign_mission": "SKYISLAND_UPGRADE_security2" } ],
Expand All @@ -216,8 +215,7 @@
"and": [
{ "not": { "u_has_mission": "SKYISLAND_UPGRADE_security3" } },
{ "math": [ "securitylevel", "==", "2" ] },
{ "math": [ "islandrank", ">=", "4" ] },
{ "math": [ "debug_never_achievable", "==", "1" ] }
{ "math": [ "islandrank", ">=", "4" ] }
]
},
"effect": [ { "assign_mission": "SKYISLAND_UPGRADE_security3" } ],
Expand All @@ -229,8 +227,7 @@
"and": [
{ "not": { "u_has_mission": "SKYISLAND_UPGRADE_security4" } },
{ "math": [ "securitylevel", "==", "3" ] },
{ "math": [ "islandrank", ">=", "4" ] },
{ "math": [ "debug_never_achievable", "==", "1" ] }
{ "math": [ "islandrank", ">=", "4" ] }
]
},
"effect": [ { "assign_mission": "SKYISLAND_UPGRADE_security4" } ],
Expand All @@ -242,8 +239,7 @@
"and": [
{ "not": { "u_has_mission": "SKYISLAND_UPGRADE_security5" } },
{ "math": [ "securitylevel", "==", "4" ] },
{ "math": [ "islandrank", ">=", "4" ] },
{ "math": [ "debug_never_achievable", "==", "1" ] }
{ "math": [ "islandrank", ">=", "4" ] }
]
},
"effect": [ { "assign_mission": "SKYISLAND_UPGRADE_security5" } ],
Expand Down
20 changes: 12 additions & 8 deletions data/mods/Sky_Island/upgrade_missions.json
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -3406,7 +3406,7 @@
"id": "SKYISLAND_UPGRADE_security2",
"type": "mission_definition",
"name": "Upgrade: Security Beta",
"description": "With the supplied recipe, you will be able to expand the capacity of your secure container.\n\nEMPTY YOUR SECURE CONTAINER FIRST! Anything left inside when upgrading will be lost forever!",
"description": "With the supplied recipe, you will be able to expand the capacity of your secure container.",
"goal": "MGOAL_FIND_ITEM",
"item": "secure_container_2",
"count": 1,
Expand All @@ -3417,7 +3417,7 @@
"effect": [
{ "u_learn_recipe": "secure_container_2" },
{
"u_message": "With the supplied recipe, you will be able to expand the capacity of your secure container.\n\nEMPTY YOUR SECURE CONTAINER FIRST! Anything left inside when upgrading will be lost forever!",
"u_message": "With the supplied recipe, you will be able to expand the capacity of your secure container.",
"popup": true
}
]
Expand All @@ -3426,6 +3426,7 @@
"effect": [
{ "math": [ "securitylevel", "=", "2" ] },
{ "u_forget_recipe": "secure_container_2" },
{ "u_lose_trait": "mut_secure_container_1" },
Copy link
Contributor

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

[JSON & C++ formatters] reported by reviewdog 🐶

Suggested change
{ "u_lose_trait": "mut_secure_container_1" },
{ "u_lose_trait": "mut_secure_container_1" },

{ "u_add_trait": "mut_secure_container_2" },
{
"u_message": "The strange metaphysical container churns inward with violent force, grinding loudly before suddenly expanding. Your secure container can now carry more.",
Expand All @@ -3452,7 +3453,7 @@
"id": "SKYISLAND_UPGRADE_security3",
"type": "mission_definition",
"name": "Upgrade: Security Gamma",
"description": "With the supplied recipe, you will be able to expand the capacity of your secure container.\n\nEMPTY YOUR SECURE CONTAINER FIRST! Anything left inside when upgrading will be lost forever!",
"description": "With the supplied recipe, you will be able to expand the capacity of your secure container.",
"goal": "MGOAL_FIND_ITEM",
"item": "secure_container_3",
"count": 1,
Expand All @@ -3463,7 +3464,7 @@
"effect": [
{ "u_learn_recipe": "secure_container_3" },
{
"u_message": "With the supplied recipe, you will be able to expand the capacity of your secure container.\n\nEMPTY YOUR SECURE CONTAINER FIRST! Anything left inside when upgrading will be lost forever!",
"u_message": "With the supplied recipe, you will be able to expand the capacity of your secure container.",
"popup": true
}
]
Expand All @@ -3472,6 +3473,7 @@
"effect": [
{ "math": [ "securitylevel", "=", "3" ] },
{ "u_forget_recipe": "secure_container_3" },
{ "u_lose_trait": "mut_secure_container_2" },
Copy link
Contributor

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

[JSON & C++ formatters] reported by reviewdog 🐶

Suggested change
{ "u_lose_trait": "mut_secure_container_2" },
{ "u_lose_trait": "mut_secure_container_2" },

{ "u_add_trait": "mut_secure_container_3" },
{
"u_message": "The strange metaphysical container churns inward with violent force, grinding loudly before suddenly expanding. Your secure container can now carry more.",
Expand All @@ -3498,7 +3500,7 @@
"id": "SKYISLAND_UPGRADE_security4",
"type": "mission_definition",
"name": "Upgrade: Security Epsilon",
"description": "With the supplied recipe, you will be able to expand the capacity of your secure container.\n\nEMPTY YOUR SECURE CONTAINER FIRST! Anything left inside when upgrading will be lost forever!",
"description": "With the supplied recipe, you will be able to expand the capacity of your secure container.",
"goal": "MGOAL_FIND_ITEM",
"item": "secure_container_4",
"count": 1,
Expand All @@ -3509,7 +3511,7 @@
"effect": [
{ "u_learn_recipe": "secure_container_4" },
{
"u_message": "With the supplied recipe, you will be able to expand the capacity of your secure container.\n\nEMPTY YOUR SECURE CONTAINER FIRST! Anything left inside when upgrading will be lost forever!",
"u_message": "With the supplied recipe, you will be able to expand the capacity of your secure container.",
"popup": true
}
]
Expand All @@ -3518,6 +3520,7 @@
"effect": [
{ "math": [ "securitylevel", "=", "4" ] },
{ "u_forget_recipe": "secure_container_4" },
{ "u_lose_trait": "mut_secure_container_3" },
Copy link
Contributor

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

[JSON & C++ formatters] reported by reviewdog 🐶

Suggested change
{ "u_lose_trait": "mut_secure_container_3" },
{ "u_lose_trait": "mut_secure_container_3" },

{ "u_add_trait": "mut_secure_container_4" },
{
"u_message": "The strange metaphysical container churns inward with violent force, grinding loudly before suddenly expanding. Your secure container can now carry more.",
Expand All @@ -3544,7 +3547,7 @@
"id": "SKYISLAND_UPGRADE_security5",
"type": "mission_definition",
"name": "Upgrade: Security Kappa",
"description": "With the supplied recipe, you will be able to expand the capacity of your secure container to its maximum size.\n\nEMPTY YOUR SECURE CONTAINER FIRST! Anything left inside when upgrading will be lost forever!",
"description": "With the supplied recipe, you will be able to expand the capacity of your secure container to its maximum size.",
"goal": "MGOAL_FIND_ITEM",
"item": "secure_container_5",
"count": 1,
Expand All @@ -3555,7 +3558,7 @@
"effect": [
{ "u_learn_recipe": "secure_container_5" },
{
"u_message": "With the supplied recipe, you will be able to expand the capacity of your secure container to its maximum size.\n\nEMPTY YOUR SECURE CONTAINER FIRST! Anything left inside when upgrading will be lost forever!",
"u_message": "With the supplied recipe, you will be able to expand the capacity of your secure container to its maximum size.",
"popup": true
}
]
Expand All @@ -3564,6 +3567,7 @@
"effect": [
{ "math": [ "securitylevel", "=", "5" ] },
{ "u_forget_recipe": "secure_container_5" },
{ "u_lose_trait": "mut_secure_container_4" },
Copy link
Contributor

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

[JSON & C++ formatters] reported by reviewdog 🐶

Suggested change
{ "u_lose_trait": "mut_secure_container_4" },
{ "u_lose_trait": "mut_secure_container_4" },

{ "u_add_trait": "mut_secure_container_5" },
{
"u_message": "The strange metaphysical container churns inward with violent force, grinding loudly before suddenly expanding. Your secure container can now carry more.",
Expand Down
Loading