[Sky Island] Make bettter security containers obtainable #75882
Conversation
By delete the debug_never_achievable line so people will able to obtainable the upgrade missions
Make sure you won't have more than 1 container
|
You are creating a pull request with the master branch as the head branch. This is likely a mistake unless you really know what you are doing. You may read https://docs.github.com/en/get-started/quickstart/contributing-to-projects#creating-a-branch-to-work-on for a typical workflow of contributing to a project on GitHub. |
github-actions
bot
added
[JSON]
![github-actions[bot]](https://avatars.githubusercontent.com/in/15368?s=60&v=4){kind=small}
| @@ -3426,6 +3426,7 @@ | |||
| "effect": [ | |||
| { "math": [ "securitylevel", "=", "2" ] }, | |||
| { "u_forget_recipe": "secure_container_2" }, | |||
| { "u_lose_trait": "mut_secure_container_1" }, | |||
There was a problem hiding this comment.
[JSON & C++ formatters] reported by reviewdog 🐶
| { "u_lose_trait": "mut_secure_container_1" }, | |
| { "u_lose_trait": "mut_secure_container_1" }, |
| @@ -3472,6 +3473,7 @@ | |||
| "effect": [ | |||
| { "math": [ "securitylevel", "=", "3" ] }, | |||
| { "u_forget_recipe": "secure_container_3" }, | |||
| { "u_lose_trait": "mut_secure_container_2" }, | |||
There was a problem hiding this comment.
[JSON & C++ formatters] reported by reviewdog 🐶
| { "u_lose_trait": "mut_secure_container_2" }, | |
| { "u_lose_trait": "mut_secure_container_2" }, |
| @@ -3518,6 +3520,7 @@ | |||
| "effect": [ | |||
| { "math": [ "securitylevel", "=", "4" ] }, | |||
| { "u_forget_recipe": "secure_container_4" }, | |||
| { "u_lose_trait": "mut_secure_container_3" }, | |||
There was a problem hiding this comment.
[JSON & C++ formatters] reported by reviewdog 🐶
| { "u_lose_trait": "mut_secure_container_3" }, | |
| { "u_lose_trait": "mut_secure_container_3" }, |
| @@ -3564,6 +3567,7 @@ | |||
| "effect": [ | |||
| { "math": [ "securitylevel", "=", "5" ] }, | |||
| { "u_forget_recipe": "secure_container_5" }, | |||
| { "u_lose_trait": "mut_secure_container_4" }, | |||
There was a problem hiding this comment.
[JSON & C++ formatters] reported by reviewdog 🐶
| { "u_lose_trait": "mut_secure_container_4" }, | |
| { "u_lose_trait": "mut_secure_container_4" }, |
|
You're fine with making a PR from a master, it just it would have problem if you want to make multiple PRs |
Summary
Make Beta security containers and better ones obtainable.
Purpose of change
There are better security containers than Alpha but unobtainable, I want to fix that.
Describe the solution
Delete the
{ "math": [ "debug_never_achievable", "==", "1" ] }condition so players can get the upgrade mission.Make sure player won't keep old container after upgrade. And change the description and message a bit because items in old container no longer lost to void.
Describe alternatives you've considered
Testing
It work, stuffs in old container drop into other pockets after I upgrade it.
Additional context
Thanks GuardianDll for point out why upgrade missions is unobtainable.