Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Clean up deagle conversion kits #75644

Merged
merged 1 commit into from
Aug 15, 2024
Merged

Clean up deagle conversion kits #75644

merged 1 commit into from
Aug 15, 2024

Conversation

GuardianDll
Copy link
Member

@GuardianDll GuardianDll commented Aug 13, 2024

Summary

None

Purpose of change

despite having "ammo": [ "NULL" ], and magazine overwriting were defined in upper receiver, deagle without conversion kit still could fit deaglemag
Aforementioned kits has mod_targets to nonexistent guns (we do not validate it?)

Describe the solution

Remove ability to install a mag inside gun without a barrel
Clean up mod_targets

Testing

image

@github-actions github-actions bot added [JSON] Changes (can be) made in JSON astyled astyled PR, label is assigned by github actions json-styled JSON lint passed, label assigned by github actions BasicBuildPassed This PR builds correctly, label assigned by github actions labels Aug 13, 2024
@GuardianDll GuardianDll marked this pull request as ready for review August 14, 2024 07:43
@Maleclypse Maleclypse merged commit 66f25e3 into master Aug 15, 2024
43 checks passed
@GuardianDll GuardianDll deleted the deagle_cleanup branch August 15, 2024 09:41
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
astyled astyled PR, label is assigned by github actions BasicBuildPassed This PR builds correctly, label assigned by github actions [JSON] Changes (can be) made in JSON json-styled JSON lint passed, label assigned by github actions
Projects
None yet
Development

Successfully merging this pull request may close these issues.

2 participants