Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

backport "Clean up deagle conversion kits" #76205

Closed
wants to merge 2 commits into from
Closed

backport "Clean up deagle conversion kits" #76205

wants to merge 2 commits into from

Conversation

GuardianDll
Copy link
Member

Summary

None

Purpose of change

0.H player reported they still can put magazine into gun with no bore, process to shoot it and, therefore, segfault it

Describe the solution

Backport #75644

@github-actions github-actions bot added [JSON] Changes (can be) made in JSON astyled astyled PR, label is assigned by github actions json-styled JSON lint passed, label assigned by github actions labels Sep 5, 2024
@Maleclypse
Copy link
Member

Thats a whole lot of errors about deagles.

@GuardianDll
Copy link
Member Author

Hmm, maybe #73714 also need to be backported? 🤔

@github-actions github-actions bot added Info / User Interface Game - player communication, menus, etc. Code: Tests Measurement, self-control, statistics, balancing. [C++] Changes (can be) made in C++. Previously named `Code` Items: Ammo / Guns Ammunition for all kinds of weapons and these weapons themselves labels Sep 10, 2024
@GuardianDll
Copy link
Member Author

i have no idea what's the problem here, and which PR should be backported to fix it

@GuardianDll GuardianDll deleted the backport_deagle branch September 12, 2024 09:44
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers
No reviews
Assignees
No one assigned
Labels
astyled astyled PR, label is assigned by github actions [C++] Changes (can be) made in C++. Previously named `Code` Code: Tests Measurement, self-control, statistics, balancing. Info / User Interface Game - player communication, menus, etc. Items: Ammo / Guns Ammunition for all kinds of weapons and these weapons themselves [JSON] Changes (can be) made in JSON json-styled JSON lint passed, label assigned by github actions
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.
2 participants
@GuardianDll @Maleclypse