Pruning the old to-hit
syntax - Part 1
#75267
Merged
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Summary
None
Purpose of change
The list has been made, someone needs to shorten it
Describe the solution
Went through
containers/containers.json
and audited all items in it that used oldto-hit
syntax, and some that didn't just to give them a sanity checkto-hit
and damage from items that weigh less than 100g at all, and the minimum bar grew with different materials (cardboard was excluded completely, for plastic and wood I kept the bar around 300g, for fabrics it was 1kg) - this actually affectedto-hit
more than it did damage, a lot of those items hadto-hit
defined, but did not have any damage definedFRAGILE_MELEE
to clay items that passed the check to have damage andto-hit
definedDescribe alternatives you've considered
Testing
Additional context
By removing the
to-hit
and bash damage (which was absurdly high for some reason for the weight of the item) of the aluminum cans, I think I might have solved the issue of NPCs wanting to throw their canned drinks at you for good?