Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Pruning the old to-hit syntax - Part 1 #75267

Merged
merged 2 commits into from
Jul 29, 2024
Merged

Conversation

Karol1223
Copy link
Contributor

Summary

None

Purpose of change

The list has been made, someone needs to shorten it

Describe the solution

Went through containers/containers.json and audited all items in it that used old to-hit syntax, and some that didn't just to give them a sanity check

  • Went and audited the bash damage based by item weight and material. Eyeballing, I'd say about 60% of the affected items got a damage buff, the remaining 40% is split between damage nerfs and removing any token damage the items did whatsoever
  • I opted to remove any to-hit and damage from items that weigh less than 100g at all, and the minimum bar grew with different materials (cardboard was excluded completely, for plastic and wood I kept the bar around 300g, for fabrics it was 1kg) - this actually affected to-hit more than it did damage, a lot of those items had to-hit defined, but did not have any damage defined
  • Other than the file mentioned above, I also went through some adjacent items that sounded similar and were on the list (foldable plastic bottle, metal bottle, fire barrels, bathroom plastic bottle)
  • Added FRAGILE_MELEE to clay items that passed the check to have damage and to-hit defined

Describe alternatives you've considered

  • Conjuring my inner wizard and doing some bullshit by adding a new material that'd make clay items break upon first hit like glass items do - didn't feel like it, and I'm not sure it's doable with just JSON alone but if I included C++ this PR would probably be borderline unreviewable
  • There was a lot of hesitation around defining bash damage values. I wish we had a guideline for those. I am not happy with the half-arbitrarily chosen values the items have right now, even after my sanity check. I tried to avoid going above bash 15 for anything that wouldn't fall apart after a single hit

Testing

Additional context

By removing the to-hit and bash damage (which was absurdly high for some reason for the weight of the item) of the aluminum cans, I think I might have solved the issue of NPCs wanting to throw their canned drinks at you for good?

@github-actions github-actions bot added [JSON] Changes (can be) made in JSON Code: Tests Measurement, self-control, statistics, balancing. Items: Containers Things that hold other things json-styled JSON lint passed, label assigned by github actions astyled astyled PR, label is assigned by github actions labels Jul 27, 2024
@Karol1223 Karol1223 closed this Jul 27, 2024
@Karol1223 Karol1223 reopened this Jul 27, 2024
@Karol1223 Karol1223 closed this Jul 27, 2024
@Karol1223 Karol1223 reopened this Jul 27, 2024
@Karol1223 Karol1223 changed the title Begin cleansing the old to-hit list - Part 1 Begin pruning the old to-hit list - Part 1 Jul 27, 2024
@github-actions github-actions bot added the BasicBuildPassed This PR builds correctly, label assigned by github actions label Jul 28, 2024
@Maleclypse Maleclypse merged commit 96167c5 into CleverRaven:master Jul 29, 2024
56 of 71 checks passed
@Karol1223 Karol1223 deleted the to-hits branch July 29, 2024 11:42
@Karol1223 Karol1223 changed the title Begin pruning the old to-hit list - Part 1 Pruning the old to-hit syntax - Part 1 Jul 29, 2024
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
astyled astyled PR, label is assigned by github actions BasicBuildPassed This PR builds correctly, label assigned by github actions Code: Tests Measurement, self-control, statistics, balancing. Items: Containers Things that hold other things [JSON] Changes (can be) made in JSON json-styled JSON lint passed, label assigned by github actions
Projects
None yet
Development

Successfully merging this pull request may close these issues.

2 participants