Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Pruning the old to-hit syntax - Part 2 #75311

Merged
merged 9 commits into from
Aug 8, 2024
Merged

Conversation

Karol1223
Copy link
Contributor

@Karol1223 Karol1223 commented Jul 29, 2024

Summary

None

Purpose of change

Continuation from #75267

Describe the solution

Going through parts of generic.json and the entirety of generic/currency.json

Methods very similar to #75267, most items here had a damage buff if were touched as well. However, these files included a lot of items that reached very high mass, and I opted not to alter their damage values too much if at all as I didn't want to accidentally make them good weapons, which my calculations would probably result in.

I opted to completely ignore the damage for items made of tree bark, unhardened clay, or powders in addition to the list from the PR linked above, however. I also opted to completely exclude the broken tent, as I could not visualize how it could be used as a weapon at all.

Describe alternatives you've considered

Testing

Additional context

@github-actions github-actions bot added [JSON] Changes (can be) made in JSON Code: Tests Measurement, self-control, statistics, balancing. labels Jul 29, 2024
@Karol1223 Karol1223 marked this pull request as draft July 29, 2024 12:26
@github-actions github-actions bot added astyled astyled PR, label is assigned by github actions json-styled JSON lint passed, label assigned by github actions labels Jul 29, 2024
@github-actions github-actions bot added the BasicBuildPassed This PR builds correctly, label assigned by github actions label Jul 29, 2024
@Karol1223 Karol1223 marked this pull request as ready for review July 29, 2024 14:45
@github-actions github-actions bot removed the BasicBuildPassed This PR builds correctly, label assigned by github actions label Jul 29, 2024
@github-actions github-actions bot removed the json-styled JSON lint passed, label assigned by github actions label Jul 29, 2024
@github-actions github-actions bot added the json-styled JSON lint passed, label assigned by github actions label Jul 29, 2024
@Karol1223 Karol1223 closed this Jul 29, 2024
@Karol1223 Karol1223 reopened this Jul 29, 2024
@github-actions github-actions bot added the BasicBuildPassed This PR builds correctly, label assigned by github actions label Jul 30, 2024
@Maleclypse Maleclypse merged commit 864157e into CleverRaven:master Aug 8, 2024
40 of 47 checks passed
@Karol1223 Karol1223 deleted the tohit branch August 9, 2024 14:19
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
astyled astyled PR, label is assigned by github actions BasicBuildPassed This PR builds correctly, label assigned by github actions Code: Tests Measurement, self-control, statistics, balancing. [JSON] Changes (can be) made in JSON json-styled JSON lint passed, label assigned by github actions
Projects
None yet
Development

Successfully merging this pull request may close these issues.

2 participants