Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Chain zombie dogs via copy-from #75102

Merged
merged 3 commits into from
Jul 20, 2024
Merged

Conversation

Karol1223
Copy link
Contributor

@Karol1223 Karol1223 commented Jul 19, 2024

Summary

None

Purpose of change

I wanted to get that out of the way before I add scorched dogs in #75071. Also to make the doggies less overlook-prone, and less intimidating. There's still some weirdness around there, but I tried to minimize the amount of actual gameplay changes this PR would bring.

Describe the solution

For the most part, just chains the dogs via copy-from, and removes some useless lines where copy-from was already present

The gameplay changes I opted to include due to being caused by flags or other similar weirdness are as follows:

  • All dogs got GROUP_BASH, to go in line with regular zombies
  • Z-9's and Rottweilers lost PUSH_MON because... they're still dogs. Barghests and Hulking Horrors still keep the flag
  • Removed the cuspated dog's tracked scents, as it didn't have SMELLS flag and the description leads me to believe it's not supposed to have a functional nose
  • Added lots of missing flags to the skeletal doggies, like WARM, BASHES, or STUMBLES. Did NOT give them SMELLS
  • Lowered the half-life for Z-9's to upgrade from 30 to 28 days
  • Removed the cuspated dog's field for grabs of 0, instead just took away the GRABS flag entirely

Describe alternatives you've considered

Including the Grim Howlers? But they're technically wolves, not dogs, so I left them out for now at least.

Testing

Additional context

@github-actions github-actions bot added [JSON] Changes (can be) made in JSON Monsters Monsters both friendly and unfriendly. labels Jul 19, 2024
@github-actions github-actions bot added astyled astyled PR, label is assigned by github actions json-styled JSON lint passed, label assigned by github actions labels Jul 19, 2024
@github-actions github-actions bot added the BasicBuildPassed This PR builds correctly, label assigned by github actions label Jul 19, 2024
@Maleclypse Maleclypse merged commit 3842d7d into CleverRaven:master Jul 20, 2024
20 of 24 checks passed
@Karol1223 Karol1223 deleted the dog-copy-from branch July 20, 2024 17:28
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
astyled astyled PR, label is assigned by github actions BasicBuildPassed This PR builds correctly, label assigned by github actions [JSON] Changes (can be) made in JSON json-styled JSON lint passed, label assigned by github actions Monsters Monsters both friendly and unfriendly.
Projects
None yet
Development

Successfully merging this pull request may close these issues.

2 participants