Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Chain zombie wolves to zombie dogs through copy-from + Remove HOWL special attack #75145

Merged
merged 1 commit into from
Jul 22, 2024

Conversation

Karol1223
Copy link
Contributor

Summary

None

Purpose of change

HOWL was an incredibly old hardcoded special with effects that made zero sense in reality. It'd only make some sense if we could have monsters from under the same ID be in different factions on wild spawn, but even then it'd be a stretch.

Also I regretted not including wolves in #75102

Describe the solution

  • Chained grim howlers to zombie dogs via copy-from - should be no gameplay difference due to this, the gameplay difference is due to me removing HOWL
  • Chained skeletal wolves to grim howlers, which also added them some missing flags
  • Removed HOWL completely, as it didn't make sense

Describe alternatives you've considered

Re-add HOWL as a noise-emitting spell, but I don't think it makes sense either. Zombie wolves howling makes the same amount of sense as zombie people screaming, so unless we wanna go into this level of granularity I don't wanna bother with this.

Testing

Additional context

@github-actions github-actions bot added [JSON] Changes (can be) made in JSON Mods Issues related to mods or modding [C++] Changes (can be) made in C++. Previously named `Code` Monsters Monsters both friendly and unfriendly. Mods: Magiclysm Anything to do with the Magiclysm mod labels Jul 21, 2024
@github-actions github-actions bot requested a review from KorGgenT July 21, 2024 12:40
@github-actions github-actions bot added astyled astyled PR, label is assigned by github actions json-styled JSON lint passed, label assigned by github actions BasicBuildPassed This PR builds correctly, label assigned by github actions labels Jul 21, 2024
@Maleclypse Maleclypse merged commit d09c6c1 into CleverRaven:master Jul 22, 2024
25 of 29 checks passed
@Karol1223 Karol1223 deleted the copy-for-the-wolf branch July 22, 2024 09:26
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
astyled astyled PR, label is assigned by github actions BasicBuildPassed This PR builds correctly, label assigned by github actions [C++] Changes (can be) made in C++. Previously named `Code` [JSON] Changes (can be) made in JSON json-styled JSON lint passed, label assigned by github actions Mods: Magiclysm Anything to do with the Magiclysm mod Mods Issues related to mods or modding Monsters Monsters both friendly and unfriendly.
Projects
None yet
Development

Successfully merging this pull request may close these issues.

2 participants